Add a call to MemoryDebug::MarkAsInitialized to the new network code to avoid...

net/base/tcp_client_socket_win.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/tcp_client_socket.h"
 
+#include "base/memory_debug.h"
 #include "base/string_util.h"
 #include "base/trace_event.h"
 #include "net/base/net_errors.h"
 #include "net/base/winsock_init.h"
 
 namespace net {
 
 //-----------------------------------------------------------------------------
 
 static int MapWinsockError(DWORD err) {
@@ skipping 151 matching lines @@
   TRACE_EVENT_BEGIN("socket.read", this, "");
   // TODO(wtc): Remove the CHECKs after enough testing.
   CHECK(WaitForSingleObject(overlapped_.hEvent, 0) == WAIT_TIMEOUT);
   DWORD num, flags = 0;
   int rv = WSARecv(socket_, &buffer_, 1, &num, &flags, &overlapped_, NULL);
   if (rv == 0) {
     CHECK(WaitForSingleObject(overlapped_.hEvent, 0) == WAIT_OBJECT_0);
     BOOL ok = WSAResetEvent(overlapped_.hEvent);
     CHECK(ok);
     TRACE_EVENT_END("socket.read", this, StringPrintf("%d bytes", num));
+
+    // Because of how WSARecv fills memory when used asynchronously, Purify
+    // isn't able to detect that it's been initialized, so it scans for 0xcd
+    // in the buffer and reports UMRs (uninitialized memory reads) for those
+    // individual bytes. We override that in PURIFY builds to avoid the false
+    // error reports.
+    // See http://code.google.com/p/chromium/issues/detail?id=5297

[darin (slow to review), 2008/12/10 17:33:29]

Can we use a more abbreviated way of referring to DIT issues?  How about
http://crbug.com/5297 or just bug 5297 since we have b/12345678 for buganizer
references?

+    base::MemoryDebug::MarkAsInitialized(buffer_.buf, num);
     return static_cast<int>(num);
   }
   int err = WSAGetLastError();
   if (err == WSA_IO_PENDING) {
     watcher_.StartWatching(overlapped_.hEvent, this);
     wait_state_ = WAITING_READ;
     callback_ = callback;
     return ERR_IO_PENDING;
   }
   return MapWinsockError(err);
@@ skipping 161 matching lines @@
       DidCompleteIO();
       break;
     default:
       NOTREACHED();
       break;
   }
 }
 
 }  // namespace net