Added command buffer implementation of WebGL which runs in the sandbox....

chrome/renderer/renderer_webkitclient_impl.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/renderer_webkitclient_impl.h"
 
 #if defined(USE_SYSTEM_SQLITE)
 #include <sqlite3.h>
 #else
 #include "third_party/sqlite/preprocessed/sqlite3.h"
 #endif
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/platform_file.h"
 #include "chrome/common/appcache/appcache_dispatcher.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/db_message_filter.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/webmessageportchannel_impl.h"
 #include "chrome/plugin/npobject_util.h"
 #include "chrome/renderer/net/render_dns_master.h"
 #include "chrome/renderer/render_thread.h"
 #include "chrome/renderer/render_view.h"
 #include "chrome/renderer/renderer_webstoragenamespace_impl.h"
 #include "chrome/renderer/visitedlink_slave.h"
+#include "chrome/renderer/webgraphicscontext3d_command_buffer_impl.h"
 #include "googleurl/src/gurl.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebFrame.h"
+#include "third_party/WebKit/WebKit/chromium/public/WebGraphicsContext3D.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebStorageEventDispatcher.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebString.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebURL.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebVector.h"
 #include "webkit/appcache/web_application_cache_host_impl.h"
 #include "webkit/glue/webkit_glue.h"
 
 #if defined(OS_LINUX)
 #include "chrome/renderer/renderer_sandbox_support_linux.h"
 #endif
@@ skipping 293 matching lines @@
 WebKit::WebSharedWorkerRepository*
 RendererWebKitClientImpl::sharedWorkerRepository() {
   if (!CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kDisableSharedWorkers)) {
     return &shared_worker_repository_;
   } else {
     return NULL;
   }
 }
 
+WebKit::WebGraphicsContext3D*
+RendererWebKitClientImpl::createGraphicsContext3D() {
+  // TODO(kbr): remove the WebGraphicsContext3D::createDefault code path
+  // completely, and at least for a period of time, either pop up a warning
+  // dialog, or don't even start the browser, if WebGL is enabled and the
+  // sandbox isn't.
+  if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kNoSandbox)) {

[darin (slow to review), 2010/03/29 15:24:32]

nit: it seems like a more specific command line switch would be better here long
term.  much as we have --in-process-plugins, a chrome developer might like to
run webgl with the command buffer code eliminated in order to reduce complexity
in the hopes of more quickly ruling out possible sources of a bug.

[Ken Russell (switch to Gerrit), 2010/03/29 19:56:30]

Good suggestion. Filed as http://crbug.com/39721 .

+    return WebKit::WebGraphicsContext3D::createDefault();
+  } else {
+#if defined(ENABLE_GPU)
+    return new WebGraphicsContext3DCommandBufferImpl();
+#else
+    return NULL;
+#endif
+  }
+}
+
 //------------------------------------------------------------------------------
 
 WebKit::WebString RendererWebKitClientImpl::signedPublicKeyAndChallengeString(
     unsigned key_size_index,
     const WebKit::WebString& challenge,
     const WebKit::WebURL& url) {
   std::string signed_public_key;
   RenderThread::current()->Send(new ViewHostMsg_Keygen(
       static_cast<uint32>(key_size_index),
       challenge.utf8(),
       GURL(url),
       &signed_public_key));
   return WebString::fromUTF8(signed_public_key);
 }