Fix extensions_service_unittest on Linux....

chrome/browser/extensions/extensions_service_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <algorithm>
 #include <vector>
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
+#include "chrome/browser/extensions/extension.h"
 #include "chrome/browser/extensions/extensions_service.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/json_value_serializer.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/platform_test.h"
 
+namespace {
+
+struct ExtensionsOrder {
+  bool operator()(const Extension* a, const Extension* b) {
+    return a->name() < b->name();
+  }
+};
+
+}  // namespace
 
 // A mock implementation of ExtensionsServiceFrontendInterface for testing the
 // backend.
 class ExtensionsServiceTestFrontend
     : public ExtensionsServiceFrontendInterface {
  public:
   ~ExtensionsServiceTestFrontend() {
     for (ExtensionList::iterator iter = extensions_.begin();
          iter != extensions_.end(); ++iter) {
       delete *iter;
@@ skipping 14 matching lines @@
   }
 
   virtual void OnExtensionLoadError(const std::string& message) {
     errors_.push_back(message);
   }
 
   virtual void OnExtensionsLoadedFromDirectory(ExtensionList* new_extensions) {
     extensions_.insert(extensions_.end(), new_extensions->begin(),
                        new_extensions->end());
     delete new_extensions;
+    // In the tests we rely on extensions being in particular order,
+    // which is not always the case (and is not guaranteed by used APIs).
+    std::stable_sort(extensions_.begin(), extensions_.end(), ExtensionsOrder());
   }
 
  private:
   MessageLoop message_loop_;
   ExtensionList extensions_;
   std::vector<std::string> errors_;
 };
 
 // make the test a PlatformTest to setup autorelease pools properly on mac
 typedef PlatformTest ExtensionsServiceTest;
@@ skipping 10 matching lines @@
       new ExtensionsServiceTestFrontend);
 
   std::vector<Extension*> extensions;
   EXPECT_TRUE(backend->LoadExtensionsFromDirectory(manifest_path,
       scoped_refptr<ExtensionsServiceFrontendInterface>(frontend.get())));
   frontend->GetMessageLoop()->RunAllPending();
 
   // Note: There can be more errors if there are extra directories, like .svn
   // directories.
   EXPECT_TRUE(frontend->errors()->size() >= 2u);
-  EXPECT_EQ(2u, frontend->extensions()->size());
+  ASSERT_EQ(2u, frontend->extensions()->size());
 
   EXPECT_EQ(std::wstring(L"com.google.myextension1"),
             frontend->extensions()->at(0)->id());
   EXPECT_EQ(std::wstring(L"My extension 1"),
             frontend->extensions()->at(0)->name());
   EXPECT_EQ(std::wstring(L"The first extension that I made."),
             frontend->extensions()->at(0)->description());
-  EXPECT_EQ(2u, frontend->extensions()->at(0)->content_scripts().size());
+  ASSERT_EQ(2u, frontend->extensions()->at(0)->content_scripts().size());
   EXPECT_EQ(std::wstring(L"script1.user.js"),
             frontend->extensions()->at(0)->content_scripts().at(0));
   EXPECT_EQ(std::wstring(L"script2.user.js"),
             frontend->extensions()->at(0)->content_scripts().at(1));
 
   EXPECT_EQ(std::wstring(L"com.google.myextension2"),
             frontend->extensions()->at(1)->id());
   EXPECT_EQ(std::wstring(L"My extension 2"),
             frontend->extensions()->at(1)->name());
   EXPECT_EQ(std::wstring(L""),
             frontend->extensions()->at(1)->description());
-  EXPECT_EQ(0u, frontend->extensions()->at(1)->content_scripts().size());
+  ASSERT_EQ(0u, frontend->extensions()->at(1)->content_scripts().size());
 };