Issue 1325004: Avoid calling ToRegister(register) when result is in register already, and re...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1325004: Avoid calling ToRegister(register) when result is in register already, and re... (Closed)

Created:
10 years, 9 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Avoid calling ToRegister(register) when result is in register already, and register is shared. Committed: http://code.google.com/p/v8/source/detail?r=4260

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -4 lines)			Patch
	M	src/ia32/virtual-frame-ia32.cc	View		1 chunk	+9 lines, -4 lines	0 comments	Download
	M	test/mjsunit/codegen-coverage.js	View		2 chunks	+13 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

William Hesse

Regression test added. Test fails without this fix.

10 years, 9 months ago (2010-03-25 11:39:19 UTC) #3

LGTM. Thanks for adding the test.