Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: layout_test_wrapper.py

Issue 13250: Strip TestShell executable before running layout tests on Mac (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/tools/buildbot/scripts/slave/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: layout_test_wrapper.py
===================================================================
--- layout_test_wrapper.py (revision 6512)
+++ layout_test_wrapper.py (working copy)
@@ -36,7 +36,7 @@
pass
webkit_tests_dir = chromium_utils.FindUpward(build_dir,
- 'webkit', 'tools', 'layout_tests')
+ 'webkit', 'tools', 'layout_tests')
run_webkit_tests = os.path.join(webkit_tests_dir, 'run_webkit_tests.py')
if sys.platform == 'win32':
@@ -60,6 +60,21 @@
slave_name = slave_utils.SlaveBuildName(build_dir)
slave_utils.StartVirtualX(slave_name)
+ if sys.platform == 'darwin':
+ # CrashReporter/ReportCrash take forever to walk through all of the
+ # debugging symbols. Since we expect crashes, strip the debugging
+ # symbols so that ReportCrash doesn't have so much to chew on.
+ # TODO(mmentovai): instead of stripping symbols, come up with a better
+ # way to suppress ReportCrash from within the TestShell process.
+ test_shell_executable = chromium_utils.FindUpward(build_dir,
+ 'xcodebuild',
+ options.target,
+ 'TestShell.app',
+ 'Contents',
+ 'MacOS',
+ 'TestShell')
+ chromium_utils.RunCommand(['strip', '-S', test_shell_executable])
+
command = [python_exe,
run_webkit_tests,
'--noshow-results',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698