Add wtf tool to provide a quick summary of pending changes.

Add wtf tool to provide a quick summary of pending changes.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=42797

[M-A Ruel, 2010-03-25 00:53:50]

http://codereview.chromium.org/1324003/diff/1/2
File wtf (right):

http://codereview.chromium.org/1324003/diff/1/2#newcode1
wtf:1: #!/usr/bin/python
Please add copyright.
Some *bsd people prefer to use env instead, see the other scripts.

http://codereview.chromium.org/1324003/diff/1/2#newcode5
wtf:5: import sys
ordering

http://codereview.chromium.org/1324003/diff/1/2#newcode8
wtf:8: """
Move the doc string above the imports

http://codereview.chromium.org/1324003/diff/1/2#newcode26
wtf:26: 
Remove all unneeded empty lines

http://codereview.chromium.org/1324003/diff/1/2#newcode30
wtf:30: cmd=['git', 'branch', '-v']
cmd = [...

http://codereview.chromium.org/1324003/diff/1/2#newcode90
wtf:90: raw = [k for k,v in env['entries'].items() if not re.search('svn', v)]
This won't fly, don't you want to parse DEPS files? Also it'll break with Var()
and From() keywords.

[Bill Richardson, 2010-03-25 17:11:34]

http://codereview.chromium.org/1324003/diff/1/2
File wtf (right):

http://codereview.chromium.org/1324003/diff/1/2#newcode90
wtf:90: raw = [k for k,v in env['entries'].items() if not re.search('svn', v)]
On 2010/03/25 00:53:50, Marc-Antoine Ruel wrote:
> This won't fly, don't you want to parse DEPS files? Also it'll break with
Var()
> and From() keywords.


No. DEPS is more complicated, and .gclient_entries is kept up to date by
gclient. Var() and From() are only in DEPS, not in .gclient_entries.

[M-A Ruel, 2010-03-25 17:25:59]

http://codereview.chromium.org/1324003/diff/5001/1002
File wtf (right):

http://codereview.chromium.org/1324003/diff/5001/1002#newcode2
wtf:2: # Copyright (c) 2009 The Chromium Authors. All rights reserved.
2010 :)

http://codereview.chromium.org/1324003/diff/5001/1002#newcode7
wtf:7: Try to figure out what I'm doing in my work space.
Can you add a short description of what it does? Example:

"""
Try to figure out what I'm doing in my work space.

Parses .gclient_entries and run git status on every entries. Doesn't support svn
at all.
"""

http://codereview.chromium.org/1324003/diff/5001/1002#newcode14
wtf:14: 
Keep 2 empty lines between function definitions

http://codereview.chromium.org/1324003/diff/5001/1002#newcode27
wtf:27: foo = 0
please use slightly less generic variable names :)

http://codereview.chromium.org/1324003/diff/5001/1002#newcode58
wtf:58: for i in range(len(here.split("/"))):
Hardcoded for posix? Please specific in the file's doc-string just to be clear.

http://codereview.chromium.org/1324003/diff/5001/1002#newcode65
wtf:65: 
Too much whitespace, this would be sufficent:

def main():
  """Prints git status. Only supported arg is --color."""
  color = os.isatty(1)
  ...

http://codereview.chromium.org/1324003/diff/5001/1002#newcode75
wtf:75: base        = os.path.basename(os.getcwd())
don't align

http://codereview.chromium.org/1324003/diff/5001/1002#newcode83
wtf:83: root = os.path.dirname(config_path)
Don't define root here, it's too "early", move it down.

http://codereview.chromium.org/1324003/diff/5001/1002#newcode89
wtf:89: raw = [k for k,v in env['entries'].items() if not re.search('svn', v)]
iteritems() is faster than items()

http://codereview.chromium.org/1324003/diff/5001/1002#newcode90
wtf:90: raw.sort()
You could use sorted([k ... ]) if it fits 80 cols.

http://codereview.chromium.org/1324003/diff/5001/1002#newcode97
wtf:97: for f,r in zip(fulldirs, reldirs):
f,r isn't really explicit.

http://codereview.chromium.org/1324003/diff/5001/1002#newcode98
wtf:98: showdir(f,r,color)
space after ','

[M-A Ruel, 2010-03-26 00:26:15]

lgtm with two optional changes

http://codereview.chromium.org/1324003/diff/9001/10001
File wtf (right):

http://codereview.chromium.org/1324003/diff/9001/10001#newcode56
wtf:56: path = filename
nit: you'd save 2 lines :)

path = filename
while os.getcwd().split('/'):
  ...

http://codereview.chromium.org/1324003/diff/9001/10001#newcode94
wtf:94: for full_path, relative_path in zip(fulldirs, reldirs):
nit: That's interesting. I'd probably have written:

for path in raw:
  show_dir(os.path.normpath(os.path.join(root, path)),
           re.sub('^' + base, '.', path),
           color)

I don't know which is more readable. I don't mind either way.