Remove DCHECKS from official builds....

Remove DCHECKS from official builds.

We keep the current behavior for regular builds:
- debug: DCHECKS enabled.
- release: DCHECKS present but inactive; can be activated through the command line.

Now we add a new behavior for official builds:
- dchecks optimized away.

B=4555


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6830

[Nicolas Sylvain, 2008-12-06 15:29:49]

I think we already have a define or something else for official build. We use it
somewhere else in the code. We should use the same instead of creating another
one.

http://codereview.chromium.org/13231/diff/1/4
File base/logging.h (right):

http://codereview.chromium.org/13231/diff/1/4#newcode316
Line 316: #else  // OFFICIAL_BUILD
The comment here is confusing, maybe we should just skip ip.

[Nicolas Sylvain, 2008-12-08 16:51:03]

we already have stuff like that :

#if defined(GOOGLE_CHROME_BUILD)
static const char* const kSbClientName = "googlechrome";
#else
static const char* const kSbClientName = "chromium";
#endif

GOOGLE_CHROME_BUILD is defined in
build\internal\chromium_build_google_chrome.vsprops

you should use that one.

[rvargas (doing something else), 2008-12-08 18:35:00]

nope. Unfortunately, you are pointing to definitions that depend on Chrome vs
Chromium. I don't think it's fair to have a Chromium "official" build (ie. with
full optimizations enabled), that still has not optimized away the DCHECKs.

On 2008/12/08 16:51:03, Nicolas Sylvain wrote:
> we already have stuff like that :
> 
> #if defined(GOOGLE_CHROME_BUILD)
> static const char* const kSbClientName = "googlechrome";
> #else
> static const char* const kSbClientName = "chromium";
> #endif
> 
> GOOGLE_CHROME_BUILD is defined in
> build\internal\chromium_build_google_chrome.vsprops
> 
> you should use that one.

[Nicolas Sylvain, 2008-12-08 18:53:05]

fair enough, you convinced me, lgtm

[sgk, 2008-12-11 21:54:39]

lgtm, modulo one indentation style nit

http://codereview.chromium.org/13231/diff/1/2
File build/internal/release_impl_official.scons (right):

http://codereview.chromium.org/13231/diff/1/2#newcode32
Line 32: 'OFFICIAL_BUILD',
Nit:  Google Python style is to indent this four spaces, not two.  (Two spaces
is only for flow-control blocks.)

[rvargas (doing something else), 2008-12-11 22:12:01]

Thanks,

Commited after addressing the comments.

On 2008/12/11 21:54:39, sgk wrote:
> lgtm, modulo one indentation style nit
> 
> http://codereview.chromium.org/13231/diff/1/2
> File build/internal/release_impl_official.scons (right):
> 
> http://codereview.chromium.org/13231/diff/1/2#newcode32
> Line 32: 'OFFICIAL_BUILD',
> Nit:  Google Python style is to indent this four spaces, not two.  (Two spaces
> is only for flow-control blocks.)