Issue 13230: Added std::string to Value via Set/GetString overloading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13230: Added std::string to Value via Set/GetString overloading. (Closed)

Created:
12 years ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
tony, brettw, Peter Kasting

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Added std::string to Value via Set/GetString overloading. All input is converted to UTF-8. Output is converted back to wide during std::wstring version of GetString(). This is part one of some more patches to come where I switch clients over to UTF-8 strings.

Patch Set 1 #

Patch Set 2 : Removed media_format files (they're a different issue) #

Patch Set 3 : Updated change as per discussion on chromium-dev. #

Patch Set 4 : Use lazy UTF-8 to Wide conversion. #

Patch Set 5 : Updated to not use caching logic. #

Patch Set 6 : Fixes build break. #

Patch Set 7 : Final upload check. #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -9 lines)			Patch
M	base/values.h	View	1 2 3 4 5	6 chunks	+12 lines, -3 lines	0 comments	Download
M	base/values.cc	View	1 2 3 4 5	7 chunks	+43 lines, -2 lines	0 comments	Download
M	base/values_unittest.cc	View	1 2 3	4 chunks	+44 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

Wasn't sure whether I should pick all of you as reviewers, or pick one and ...

12 years ago (2008-12-10 03:23:48 UTC) #1

Thanks! LGTM

Expand Messages | Collapse Messages