Change how version_build_patch is computed to allow PATCH > 255

Change how version_build_patch is computed to allow PATCH > 255

version_build_patch is built as BUILD.PATCH and then used to set
DYLIB_CURRENT_VERSION and DYLIB_COMPATIBILITY_VERSION on Mac OS X.

These VERSION strings have the format X.Y.Z, where X cannot exceed 65535 and Y
and Z cannot exceed 255 (see the ld man page).

In order to allow PATCH to exceed 255, change version_build_patch to
BUILD.PATCH/256.PATCH%256.

BUG=39244
TEST=Set PATCH > 255 in chrome/VERSION, rebuild, and use otool -L to confirm
     version

Patch by Jay Soffian <jaysoffian@gmail.com>;

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42771

[Mark Mentovai, 2010-03-25 01:46:08]

http://codereview.chromium.org/1322002/diff/9001/10001
File chrome/chrome.gyp (right):

http://codereview.chromium.org/1322002/diff/9001/10001#newcode16
chrome/chrome.gyp:16: 'version_build_patch':
This is no longer really build_patch, but a specific version format used for the
Mach-O LC_ID_DYLIB version number.  The variable name should be updated to
reflect this.

http://codereview.chromium.org/1322002/diff/9001/10002
File chrome/tools/build/version.py (right):

http://codereview.chromium.org/1322002/diff/9001/10002#newcode123
chrome/tools/build/version.py:123: -e 'PATCH_MAJOR=int(PATCH)/256'.
You should use PATCH_HI here so that the example matches the actual use in
chrome.gyp.

[jaysoffian, 2010-03-25 02:09:14]

Thanks for the feedback. I've addressed it in patch set 3.

[Mark Mentovai, 2010-03-26 16:28:16]

LGTM.  I’ll check this in.  Thanks for the patch.

[Mark Mentovai, 2010-03-26 16:32:14]

r42771