Issue 13214: Handle destruction of test shell properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13214: Handle destruction of test shell properly. (Closed)

Created:
12 years ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
tony, Feng Qian, dank

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Handle destruction of test shell properly. When test shell's destructor runs, it tries to delete its child objects. But when the GTK widgets are destroyed, they also try to delete the associated objects. We don't want both to run. Also, there were a couple of incorrect uses of the GTK API (e.g. destroy-event instead of destroy) that were obfuscating the problem. This fixes a crash on shutdown, so I'm restoring the LoadURL() call in TestShell's destructor.

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -29 lines)			Patch
M	webkit/tools/test_shell/test_shell.cc	View	1 chunk	+24 lines, -20 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_gtk.cc	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/webwidget_host_gtk.cc	View	3 chunks	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM2 On 2008/12/05 22:18:29, dank wrote: > LGTM. (I'm no GTK expert, but I checked ...

12 years ago (2008-12-05 23:37:53 UTC) #3

Feng Qian

12 years ago (2008-12-06 01:03:15 UTC) #4

Restoring LoadURL lgtm.

On 2008/12/05 23:37:53, tony wrote:
> LGTM2
> 
> On 2008/12/05 22:18:29, dank wrote:
> > LGTM.  (I'm no GTK expert, but I checked as well as I could.)

Expand Messages | Collapse Messages