Issue 1321002: Reducing the debug output spam.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1321002: Reducing the debug output spam. (Closed)

Created:
10 years, 9 months ago by ahendrickson

Modified:
9 years, 7 months ago

Reviewers:
cbentzel, wtc, willchan no longer on Chromium

CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Reducing the debug output spam. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42694

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 9 months ago

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -29 lines)
M	net/http/http_network_transaction.cc	View	2 chunks	+0 lines, -2 lines	0 comments
M	net/spdy/spdy_network_transaction_unittest.cc	View	5 chunks	+15 lines, -15 lines	0 comments
M	net/spdy/spdy_session.cc	View	4 chunks	+0 lines, -4 lines	0 comments
M	net/spdy/spdy_stream.cc	View	6 chunks	+0 lines, -8 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

wtc and i would prefer getting rid of all the new DLOGs, including the NET_TRACE ...

10 years, 9 months ago (2010-03-25 23:16:28 UTC) #1

wtc

10 years, 9 months ago (2010-03-26 00:11:14 UTC) #3

LGTM.

In general I don't like checking in log messages for tracing
the control flow, because they usually only make sense to the
programmer who added them, and are a hassle for others to
maintain.

Expand Messages | Collapse Messages