Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1648)

Unified Diff: chrome/chrome.gyp

Issue 132032: [chromium-reviews] Add unit testing to CLD. In addition, remove files from cld/base which are no... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/compact_lang_det_unittest_small.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome.gyp
===================================================================
--- chrome/chrome.gyp (revision 19085)
+++ chrome/chrome.gyp (working copy)
@@ -3342,6 +3342,14 @@
'include_dirs': [
'..',
],
+ 'defines': [
+ 'CLD_WINDOWS',
+ ],
+ 'direct_dependent_settings': {
+ 'defines': [
+ 'CLD_WINDOWS',
+ ],
+ },
'sources': [
'app/breakpad_mac_stubs.mm',
# *NO* files in chrome/app have unit tests (except keystone_glue)!!!
@@ -3565,6 +3573,7 @@
'test/test_notification_tracker.h',
'test/v8_unit_test.cc',
'test/v8_unit_test.h',
+ '../third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/compact_lang_det_unittest_small.cc',
'../views/controls/label_unittest.cc',
'../views/controls/table/table_view_unittest.cc',
@@ -3587,6 +3596,8 @@
# might want to write our own tests for the download manager
# on linux, though.
'browser/download/download_manager_unittest.cc',
+ # Compact Language Detection (cld) is not supported in linux yet.
+ '../third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/compact_lang_det_unittest_small.cc',
],
}],
['OS=="linux" and toolkit_views==1', {
@@ -3614,6 +3625,9 @@
'test/test_notification_tracker.cc',
'test/test_notification_tracker.h',
'third_party/hunspell/google/hunspell_tests.cc',
+
+ # Compact Language Detection (cld) is not supported in mac yet.
+ '../third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/compact_lang_det_unittest_small.cc',
],
# TODO(mark): We really want this for all non-static library targets,
# but when we tried to pull it up to the common.gypi level, it broke
« no previous file with comments | « no previous file | third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/compact_lang_det_unittest_small.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698