Issue 132032: [chromium-reviews] Add unit testing to CLD. In addition, remove files from cld/base which are no...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132032: [chromium-reviews] Add unit testing to CLD. In addition, remove files from cld/base which are no... (Closed)

Created:
11 years, 6 months ago by sidchat (Google)

Modified:
9 years, 7 months ago

Reviewers:
brettw, bradn

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add unit testing to CLD. In addition, remove files from cld/base which are not required, yet were creating compile errors when building unit_tests. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19190

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+412 lines, -917 lines)			Patch
M	chrome/chrome.gyp	View	3 4	4 chunks	+14 lines, -0 lines	0 comments	Download
A	third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/compact_lang_det_unittest_small.cc	View	1 2 3 4	1 chunk	+391 lines, -0 lines	0 comments	Download
M	third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_google.h	View	1 2	2 chunks	+7 lines, -1 line	0 comments	Download
D	third_party/cld/base/callback.h	View	1 2	1 chunk	+0 lines, -308 lines	0 comments	Download
D	third_party/cld/base/closure.h	View	1 2	1 chunk	+0 lines, -12 lines	0 comments	Download
D	third_party/cld/base/google.h	View	1 2	1 chunk	+0 lines, -212 lines	0 comments	Download
D	third_party/cld/base/googleinit.h	View	1 2	1 chunk	+0 lines, -384 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years, 6 months ago (2009-06-22 19:11:28 UTC) #2

LGTM

http://codereview.chromium.org/132032/diff/1004/25
File chrome/test/unit/unittests.vcproj (right):

http://codereview.chromium.org/132032/diff/1004/25#newcode1208
Line 1208: Name="third_party"
This seems excessive to put all these folders here. I would put it in
third_party/cld and nothing more.

Expand Messages | Collapse Messages