Issue 132029: Call Layout directly from SetContentsView. In the case where the Widget is cr...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132029: Call Layout directly from SetContentsView. In the case where the Widget is cr... (Closed)

Created:
11 years, 6 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Call Layout directly from SetContentsView. In the case where the Widget is created with bounds, SetContentsView never causes a subsequent Layout because the bounds won't have changed. Fixes interactive UI tests. TBR=sky BUG=none TEST=interactive ui tests don't crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18729

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	views/widget/widget_gtk.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	views/widget/widget_win.cc	View		1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages