Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 132021: Two requested changes to tick processor. (Closed)

Created:
11 years, 6 months ago by Mikhail Naganov
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Two requested changes to tick processor. 1. If D8_PATH isn't specified, first try to locate 'd8' shell in path, and if not found, fallback to the one in tools_path/.. 2. Add '--nm=<nm_exec>' parameter to specify 'nm' executable to use. Committed: http://code.google.com/p/v8/source/detail?r=2225

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M tools/linux-tick-processor View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/tickprocessor.js View 6 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mikhail Naganov
11 years, 6 months ago (2009-06-18 15:28:31 UTC) #1
Erik Corry
11 years, 6 months ago (2009-06-19 21:50:47 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698