Issue 1320011: linux: turn on -Wextra

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1320011: linux: turn on -Wextra (Closed)

Created:
10 years, 9 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, agl

Visibility:
Public.

Description

linux: turn on -Wextra This is a followup to an earlier change (r38266) which did most of the warning-related cleanup. This one just flips the flag, and fixes some new warnings that crept in during the window while the flag was off. Second try, now with some libpng fixes. BUG=34160 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42700

Patch Set 1 #

Patch Set 2 : fixed #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -73 lines)			Patch
M	build/common.gypi	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gfx/codec/png_codec.cc	View	1	3 chunks	+52 lines, -48 lines	0 comments	Download
M	sandbox/linux/seccomp/library.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sandbox/linux/seccomp/library.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sandbox/linux/seccomp/sandbox_impl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sandbox/linux/seccomp/socketcall.cc	View		3 chunks	+3 lines, -5 lines	0 comments	Download
M	sandbox/linux/suid/linux_util.c	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	sandbox/linux/suid/process_util_linux.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sandbox/linux/suid/sandbox.c	View		4 chunks	+12 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

10 years, 9 months ago (2010-03-25 23:52:38 UTC) #2

LGTM on the png encoder change. This is much more clear than using
PngWriteStructDestroyer.

Expand Messages | Collapse Messages