Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1320010: VBoot Reference: Add kernel rollback prevention and choosing logic. (Closed)

Created:
10 years, 9 months ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
Chris Masone
CC:
chromium-os-reviews_chromium.org, Will Drewry, gauravsh, davidjames, Chris Masone, Daniel Erat, Sameer Nanda, sosa
Visibility:
Public.

Description

VBoot Reference: Add kernel rollback prevention and choosing logic. Also adds tests for kernel rollback prevention.

Patch Set 1 #

Patch Set 2 : merge branch #

Patch Set 3 : Add more tests #

Total comments: 2

Patch Set 4 : fix priority in test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+408 lines, -25 lines) Patch
M src/platform/vboot_reference/include/kernel_image.h View 1 2 chunks +43 lines, -0 lines 0 comments Download
M src/platform/vboot_reference/tests/Makefile View 1 2 3 chunks +6 lines, -0 lines 0 comments Download
M src/platform/vboot_reference/tests/firmware_rollback_tests.c View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/platform/vboot_reference/tests/kernel_image_tests.c View 1 1 chunk +0 lines, -3 lines 0 comments Download
A src/platform/vboot_reference/tests/kernel_rollback_tests.c View 1 2 3 1 chunk +149 lines, -0 lines 0 comments Download
M src/platform/vboot_reference/tests/rollback_index_mock.c View 2 chunks +6 lines, -0 lines 0 comments Download
M src/platform/vboot_reference/tests/test_common.h View 1 2 1 chunk +10 lines, -3 lines 0 comments Download
M src/platform/vboot_reference/tests/test_common.c View 1 2 3 chunks +35 lines, -5 lines 0 comments Download
M src/platform/vboot_reference/utils/firmware_image.c View 1 2 chunks +10 lines, -10 lines 0 comments Download
M src/platform/vboot_reference/utils/kernel_image.c View 1 2 2 chunks +145 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gauravsh
10 years, 9 months ago (2010-03-25 23:25:29 UTC) #1
Chris Masone
http://codereview.chromium.org/1320010/diff/5001/6005 File src/platform/vboot_reference/tests/kernel_rollback_tests.c (right): http://codereview.chromium.org/1320010/diff/5001/6005#newcode46 src/platform/vboot_reference/tests/kernel_rollback_tests.c:46: 15, /* Lower Priority. */ Did you mean this ...
10 years, 9 months ago (2010-03-26 16:02:37 UTC) #2
gauravsh
http://codereview.chromium.org/1320010/diff/5001/6005 File src/platform/vboot_reference/tests/kernel_rollback_tests.c (right): http://codereview.chromium.org/1320010/diff/5001/6005#newcode46 src/platform/vboot_reference/tests/kernel_rollback_tests.c:46: 15, /* Lower Priority. */ On 2010/03/26 16:02:37, cmasone ...
10 years, 9 months ago (2010-03-26 17:21:02 UTC) #3
Chris Masone
10 years, 9 months ago (2010-03-26 17:26:35 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698