Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1320005: Adds GeolocationContentSettings on TabContents. ... (Closed)

Created:
10 years, 9 months ago by joth
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, jam+cc_chromium.org, ben+cc_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Adds GeolocationContentSettings on TabContents. This data structure and the notification flow will be used to populate the location bar icon and its bubble. - this was originally part of http://codereview.chromium.org/650180 - Fully reviewed as http://codereview.chromium.org/1143002 I'm just landing on Marcus's behalf TBR=bulach BUG=11246 TEST=geolocation_browsertest.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42594

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -39 lines) Patch
M chrome/browser/geolocation/geolocation_browsertest.cc View 15 chunks +52 lines, -20 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context.cc View 3 chunks +16 lines, -6 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 5 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 3 chunks +15 lines, -0 lines 0 comments Download
M chrome/test/data/geolocation/iframes_different_origin.html View 1 chunk +15 lines, -12 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698