Issue 13197: Unfork TextCodecICU.cpp. The upstream accepted my patch with some changes ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13197: Unfork TextCodecICU.cpp. The upstream accepted my patch with some changes ... (Closed)

Created:
12 years ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Unfork TextCodecICU.cpp. The upstream accepted my patch with some changes (r39021, http://bugs.webkit.org/show_bug.cgi?id=22116 ) We can now unfork this file. fast/encoding/char-decoding.html was revised as well. It should be enabled once we merge with r39021 or later. A new test (fast/encoding/char-decoding-mac.html) should be added to tests_ignored.txt when doing a merge. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6540

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -25 lines)			Patch
	M	third_party/WebKit/WebCore/platform/text/TextCodecICU.cpp	View		4 chunks	+24 lines, -25 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages