Issue 1317003: Align OProfile agent invocations style with logging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1317003: Align OProfile agent invocations style with logging. (Closed)

Created:
10 years, 9 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Align OProfile agent invocations style with logging. This allows to unclutter logging-related code. I also fixed compilation issues with 'profilingsupport=off'. Committed: http://code.google.com/p/v8/source/detail?r=4285

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -104 lines)			Patch
M	src/code-stubs.cc	View	1 chunk	+3 lines, -7 lines	0 comments	Download
M	src/compiler.h	View	1 chunk	+6 lines, -9 lines	0 comments	Download
M	src/compiler.cc	View	5 chunks	+39 lines, -53 lines	0 comments	Download
M	src/oprofile-agent.h	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	src/oprofile-agent.cc	View	2 chunks	+25 lines, -33 lines	0 comments	Download
M	src/platform.h	View	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages