Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: base/values.h

Issue 13169: Add error messages to JSONReader and friends. This required a bit of refactor... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/values.h
===================================================================
--- base/values.h (revision 6390)
+++ base/values.h (working copy)
@@ -352,8 +352,10 @@
// The method should return true if and only if the root parameter is set
// to a complete Value representation of the serialized form. If the
// return value is true, the caller takes ownership of the objects pointed
- // to by root. If the return value is false, root should be unchanged.
- virtual bool Deserialize(Value** root) = 0;
+ // to by root. If the return value is false, root should be unchanged and if
+ // error_message is non-null, it should be filled with a message describing
+ // the error.
+ virtual bool Deserialize(Value** root, std::string* error_message) = 0;
};
#endif // BASE_VALUES_H_

Powered by Google App Engine
This is Rietveld 408576698