Issue 13166: Clean up junk in content sniffing mock-http-headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13166: Clean up junk in content sniffing mock-http-headers. (Closed)

Created:
12 years ago by abarth-chromium

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Clean up junk in content sniffing mock-http-headers. R=deanm Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6423

Patch Set 1 #

Total comments: 2

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -12 lines)			Patch
M	chrome/test/data/content-sniffer-test0.html.mock-http-headers	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/test/data/content-sniffer-test1.html.mock-http-headers	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/test/data/content-sniffer-test2.html.mock-http-headers	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/test/data/content-sniffer-test3-frame.txt.mock-http-headers	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/data/content-sniffer-test3.html.mock-http-headers	View	1 chunk	+1 line, -3 lines	2 comments	Download
M	chrome/test/data/nosniff-test.html.mock-http-headers	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

Looks great, I assume the tests still pass :) Thanks! http://codereview.chromium.org/13166/diff/1/2 File chrome/test/data/content-sniffer-test3.html.mock-http-headers (right): http://codereview.chromium.org/13166/diff/1/2#newcode2 ...

12 years ago (2008-12-05 07:36:20 UTC) #2

abarth-chromium

On 2008/12/05 07:36:20, Dean McNamee wrote: > Looks great, I assume the tests still pass ...

12 years ago (2008-12-05 07:39:53 UTC) #3

abarth-chromium

12 years ago (2008-12-05 07:39:58 UTC) #4

http://codereview.chromium.org/13166/diff/1/2
File chrome/test/data/content-sniffer-test3.html.mock-http-headers (right):

http://codereview.chromium.org/13166/diff/1/2#newcode2
Line 2: Content-Length: 472
On 2008/12/05 07:36:20, Dean McNamee wrote:
> Were both the old content length's wrong and it just didn't matter?

Looks that way.  I got the new value with wc -c.  I don't think this test is
mean to test this behavior so I thought it best to use the correct value.

Expand Messages | Collapse Messages