Add fuzzy image matching tool for Linux pixel tests

Add fuzzy image matching tool for Linux pixel tests

[Evan Martin, 2008-12-05 02:31:25]

Tony gets this one!

[tony, 2008-12-05 02:52:28]

I think I'm also missing the .py changes that actually call fuzzymatch?

Also, why weren't you able to make a SConscript file for this?  I would also be
ok with a stand alone SConscript file, although one integrated into the build
would be better.

http://codereview.chromium.org/13159/diff/1/2
File tools/fuzzymatch/fuzzymatch.c (right):

http://codereview.chromium.org/13159/diff/1/2#newcode1
Line 1: /* Fuzzy pixel test matching.
Nit: Missing license header.  Also, I think we prefer lots of // rather than C++
block comments.

http://codereview.chromium.org/13159/diff/1/2#newcode34
Line 34: *   % gcc -o fuzzymatch fuzzymatch.c -llept -ljpeg -ltiff -lpng -lz -lm
-Wall -O2
Nit: 80 cols.

http://codereview.chromium.org/13159/diff/1/2#newcode37
Line 37: #include <unistd.h>
Nit: sort these headers

http://codereview.chromium.org/13159/diff/1/2#newcode42
Line 42: usage(const char *argv0) {
Nit: return type on the same line and char*

http://codereview.chromium.org/13159/diff/1/2#newcode48
Line 48: main(int argc, char **argv) {
Nit: return type on the same line and char**

http://codereview.chromium.org/13159/diff/1/2#newcode52
Line 52: PIX *a = pixRead(argv[1]);
Nit *'s (etc)

http://codereview.chromium.org/13159/diff/1/3
File webkit/tools/layout_tests/layout_package/test_failures.py (right):

http://codereview.chromium.org/13159/diff/1/3#newcode207
Line 207: OUT_FILENAMES = ["-actual-win.png", "-expected.png"]
Will this collide with the regular pixel files?  Maybe -fuzzy should be in the
OUT_FILENAMES?

http://codereview.chromium.org/13159/diff/1/4
File webkit/tools/layout_tests/run_webkit_tests.py (right):

http://codereview.chromium.org/13159/diff/1/4#newcode43
Line 43: from test_types import fuzzy_image_diff
nit: I think this should come before image_diff.

[agl, 2008-12-05 18:08:50]

Moved to 3rdparty, added license block and generic SConscript file.

http://codereview.chromium.org/13159/diff/1/3
File webkit/tools/layout_tests/layout_package/test_failures.py (right):

http://codereview.chromium.org/13159/diff/1/3#newcode207
Line 207: OUT_FILENAMES = ["-actual-win.png", "-expected.png"]
On 2008/12/05 02:52:28, tony wrote:
> Will this collide with the regular pixel files?  Maybe -fuzzy should be in the
> OUT_FILENAMES?

These provide the links to the image files - basically the "actual" and
"expected" links. Since I don't have any better outputs these just link to the
same images as an image match failure.

http://codereview.chromium.org/13159/diff/1/4
File webkit/tools/layout_tests/run_webkit_tests.py (right):

http://codereview.chromium.org/13159/diff/1/4#newcode43
Line 43: from test_types import fuzzy_image_diff
On 2008/12/05 02:52:28, tony wrote:
> nit: I think this should come before image_diff.

Done.

[tony, 2008-12-05 18:20:34]

LGTM

On 2008/12/05 18:08:50, agl wrote:
> Moved to 3rdparty, added license block and generic SConscript file.
> 
> http://codereview.chromium.org/13159/diff/1/3
> File webkit/tools/layout_tests/layout_package/test_failures.py (right):
> 
> http://codereview.chromium.org/13159/diff/1/3#newcode207
> Line 207: OUT_FILENAMES = ["-actual-win.png", "-expected.png"]
> On 2008/12/05 02:52:28, tony wrote:
> > Will this collide with the regular pixel files?  Maybe -fuzzy should be in
the
> > OUT_FILENAMES?
> 
> These provide the links to the image files - basically the "actual" and
> "expected" links. Since I don't have any better outputs these just link to the
> same images as an image match failure.
> 
> http://codereview.chromium.org/13159/diff/1/4
> File webkit/tools/layout_tests/run_webkit_tests.py (right):
> 
> http://codereview.chromium.org/13159/diff/1/4#newcode43
> Line 43: from test_types import fuzzy_image_diff
> On 2008/12/05 02:52:28, tony wrote:
> > nit: I think this should come before image_diff.
> 
> Done.