chrome/views/combo_box.cc - Issue 13156: Fix a crash on 64-bit systems when an external message hook is installed. The...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/views/combo_box.cc

Issue 13156: Fix a crash on 64-bit systems when an external message hook is installed. The... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 12 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/views/combo_box.cc

===================================================================

--- chrome/views/combo_box.cc (revision 6387)

+++ chrome/views/combo_box.cc (working copy)

@@ -39,7 +39,9 @@

COMBOBOXINFO cbi;

memset(reinterpret_cast<unsigned char*>(&cbi), 0, sizeof(cbi));

cbi.cbSize = sizeof(cbi);

- ::SendMessage(hwnd, CB_GETCOMBOBOXINFO, 0, reinterpret_cast<LPARAM>(&cbi));

+ // Note: Don't use CB_GETCOMBOBOXINFO since that crashes on WOW64 systems

+ // when you have a global message hook installed.

+ GetComboBoxInfo(hwnd, &cbi);

gfx::Rect rect_item(cbi.rcItem);

gfx::Rect rect_button(cbi.rcButton);

gfx::Size border = gfx::NativeTheme::instance()->GetThemeBorderSize(

« no previous file with comments | « no previous file | no next file » | no next file with comments »