Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1315007: Added tearing tests for plain texture updates and bind pixmap to texture. (Closed)

Created:
10 years, 9 months ago by Alexey Marinichev
Modified:
9 years, 7 months ago
Reviewers:
piman
CC:
chromium-os-reviews_chromium.org, kmixter1, petkov, seano, ericli, sosa
Visibility:
Public.

Description

Added tearing tests for plain texture updates and bind pixmap to texture.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -41 lines) Patch
M client/deps/glbench/src/Makefile View 1 chunk +2 lines, -0 lines 0 comments Download
A client/deps/glbench/src/glx_stuff.h View 1 chunk +13 lines, -0 lines 0 comments Download
M client/deps/glbench/src/glx_stuff.cc View 4 chunks +10 lines, -10 lines 0 comments Download
A client/deps/glbench/src/teartest.h View 1 chunk +26 lines, -0 lines 0 comments Download
M client/deps/glbench/src/teartest.cc View 5 chunks +124 lines, -30 lines 0 comments Download
A client/deps/glbench/src/teartest_egl.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A client/deps/glbench/src/teartest_glx.cc View 1 chunk +72 lines, -0 lines 0 comments Download
M client/deps/glbench/src/xlib_window.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexey Marinichev
10 years, 9 months ago (2010-03-25 03:55:19 UTC) #1
piman
LGTM. For your tests if you want cleaner startup/shutdown, it should be easy to turn ...
10 years, 9 months ago (2010-03-25 19:54:09 UTC) #2
Alexey Marinichev
10 years, 9 months ago (2010-03-25 20:04:22 UTC) #3
On 2010/03/25 19:54:09, piman wrote:
> LGTM.
> 
> For your tests if you want cleaner startup/shutdown, it should be easy to turn
> them into classes with virtual Start(), Loop() and Stop() as well as a
factory.
> Then you don't have to litter the code with global/function statics. But that
> can be a separate CL.

Thanks for the idea.  When I was adding those functions I thought that's what
classes are for.  But it was an incremental change from something that worked
OK, so I decided to not change everything all at once :-)

Checking in as is, will switch to C++ ways later.

Powered by Google App Engine
This is Rietveld 408576698