Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: site_scons/site_tools/component_setup.py

Issue 13134: Pulling in hammer changes. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « site_scons/site_tools/component_bits.py ('k') | site_scons/site_tools/component_targets.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: site_scons/site_tools/component_setup.py
===================================================================
--- site_scons/site_tools/component_setup.py (revision 6345)
+++ site_scons/site_tools/component_setup.py (working copy)
@@ -70,9 +70,11 @@
Args:
env: Environment for the current build mode.
"""
- # Convert directory variables to strings
+ # Convert directory variables to strings. Must use .abspath not str(), since
+ # otherwise $OBJ_ROOT is converted to a relative path, which evaluates
+ # improperly in SConscripts not in $MAIN_DIR.
for var in env.SubstList2('$PRE_EVALUATE_DIRS'):
- env[var] = str(env.Dir('$' + var))
+ env[var] = env.Dir('$' + var).abspath
#------------------------------------------------------------------------------
@@ -195,6 +197,46 @@
# default to do so after including the component_setup tool.
env.Default('$DESTINATION_ROOT')
+ # Use brief command line strings if necessary
+ SCons.Script.Help("""\
+ --verbose Print verbose output while building, including
+ the full command lines for all commands.
+ --brief Print brief output while building (the default).
+ This and --verbose are opposites. Use --silent
+ to turn off all output.
+""")
+ SCons.Script.AddOption(
+ '--brief',
+ dest='brief_comstr',
+ default=True,
+ action='store_true',
+ help='brief command line output')
+ SCons.Script.AddOption(
+ '--verbose',
+ dest='brief_comstr',
+ default=True,
+ action='store_false',
+ help='verbose command line output')
+ if env.GetOption('brief_comstr'):
+ env.SetDefault(
+ ARCOMSTR='________Creating library $TARGET',
+ ASCOMSTR='________Assembling $TARGET',
+ CCCOMSTR='________Compiling $TARGET',
+ CONCAT_SOURCE_COMSTR='________ConcatSource $TARGET',
+ CXXCOMSTR='________Compiling $TARGET',
+ LDMODULECOMSTR='________Building loadable module $TARGET',
+ LINKCOMSTR='________Linking $TARGET',
+ MANIFEST_COMSTR='________Updating manifest for $TARGET',
+ MIDLCOMSTR='________Compiling IDL $TARGET',
+ PCHCOMSTR='________Precompiling $TARGET',
+ RANLIBCOMSTR='________Indexing $TARGET',
+ RCCOMSTR='________Compiling resource $TARGET',
+ SHCCCOMSTR='________Compiling $TARGET',
+ SHCXXCOMSTR='________Compiling $TARGET',
+ SHLINKCOMSTR='________Linking $TARGET',
+ SHMANIFEST_COMSTR='________Updating manifest for $TARGET',
+ )
+
# Add other default tools from our toolkit
# TODO(rspangler): Currently this needs to be before SOURCE_ROOT in case a
# tool needs to redefine it. Need a better way to handle order-dependency
« no previous file with comments | « site_scons/site_tools/component_bits.py ('k') | site_scons/site_tools/component_targets.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698