This adds in the GYP files needed for our GYP build.

This adds in the GYP files needed for our GYP build,
and modifies the DEPS file extensively to match.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19091

[bradn, 2009-06-24 00:59:37]

Few nit, but LGTM

http://codereview.chromium.org/131116/diff/2001/2013
File DEPS.gyp (right):

http://codereview.chromium.org/131116/diff/2001/2013#newcode1
Line 1: vars = {
A little odd calling this .gyp
How about DEPS_gyp, nah whatever....

http://codereview.chromium.org/131116/diff/2001/2019
File breakpad/breakpad.gyp (right):

http://codereview.chromium.org/131116/diff/2001/2019#newcode1
Line 1: # Copyright (c) 2009 The Chromium Authors. All rights reserved.
Was there a reason you couldn't share the existing breakpad for chrome?

http://codereview.chromium.org/131116/diff/2001/2012
File build/build_nacl.py (right):

http://codereview.chromium.org/131116/diff/2001/2012#newcode22
Line 22: import os.path
sort the imports, and os ==> os.path

http://codereview.chromium.org/131116/diff/2001/2012#newcode43
Line 43: 
I believe the style guide requires:
Two blank lines between top-level definitions, one blank line between method
definitions.

http://codereview.chromium.org/131116/diff/2001/2011
File build/common.gypi (right):

http://codereview.chromium.org/131116/diff/2001/2011#newcode23
Line 23: [ 'OS == "win"',
Minor nit, I believe in other gyp's there no space between [ and ', but if you
feel strongly, I don't really care.

http://codereview.chromium.org/131116/diff/2001/2010
File build/nacl.gyp (right):

http://codereview.chromium.org/131116/diff/2001/2010#newcode37
Line 37: 'C:/Python24/python.exe',
Not sure you can assume this. Left over from using your own I assume?

http://codereview.chromium.org/131116/diff/2001/2015
File plugin/version_info.py (right):

http://codereview.chromium.org/131116/diff/2001/2015#newcode21
Line 21: import os.path
don't need os.path + sort

http://codereview.chromium.org/131116/diff/2001/2015#newcode47
Line 47: 
Same spacing thing...

[Greg Spencer, 2009-06-24 01:41:19]

http://codereview.chromium.org/131116/diff/2001/2013
File DEPS.gyp (right):

http://codereview.chromium.org/131116/diff/2001/2013#newcode1
Line 1: vars = {
On 2009/06/24 00:59:37, bradn wrote:
> A little odd calling this .gyp
> How about DEPS_gyp, nah whatever....

No, I can change it, no problem.

http://codereview.chromium.org/131116/diff/2001/2019
File breakpad/breakpad.gyp (right):

http://codereview.chromium.org/131116/diff/2001/2019#newcode1
Line 1: # Copyright (c) 2009 The Chromium Authors. All rights reserved.
On 2009/06/24 00:59:37, bradn wrote:
> Was there a reason you couldn't share the existing 
> breakpad for chrome?

Hmm.  No, no real reason -- I guess that I just didn't look at the chrome
src/breakpad dir (and I didn't see a gyp file in third_party/breakpad).  I'll
switch it over to use the one that chrome uses, but we still need this .gyp file
so we can add in our own blue screen detector, etc.

http://codereview.chromium.org/131116/diff/2001/2012
File build/build_nacl.py (right):

http://codereview.chromium.org/131116/diff/2001/2012#newcode22
Line 22: import os.path
On 2009/06/24 00:59:37, bradn wrote:
> sort the imports, and os ==> os.path

Actually, I need os and os.path.  I'll remove the os.path.

http://codereview.chromium.org/131116/diff/2001/2012#newcode43
Line 43: 
On 2009/06/24 00:59:37, bradn wrote:
> I believe the style guide requires:
> Two blank lines between top-level definitions, one blank line between method
> definitions. 

Done.

http://codereview.chromium.org/131116/diff/2001/2011
File build/common.gypi (right):

http://codereview.chromium.org/131116/diff/2001/2011#newcode23
Line 23: [ 'OS == "win"',
On 2009/06/24 00:59:37, bradn wrote:
> Minor nit, I believe in other gyp's there no space between [ and ', but if you
> feel strongly, I don't really care.

I don't feel strongly.  Fixed this in all files.

http://codereview.chromium.org/131116/diff/2001/2010
File build/nacl.gyp (right):

http://codereview.chromium.org/131116/diff/2001/2010#newcode37
Line 37: 'C:/Python24/python.exe',
On 2009/06/24 00:59:37, bradn wrote:
> Not sure you can assume this. Left over from using your own I assume?

Whoops!  Yeah, I was making it work with the broken-on-vista python.

http://codereview.chromium.org/131116/diff/2001/2015
File plugin/version_info.py (right):

http://codereview.chromium.org/131116/diff/2001/2015#newcode21
Line 21: import os.path
On 2009/06/24 00:59:37, bradn wrote:
> don't need os.path + sort

Actually, I don't need 'import os'. Done.