Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Issue 131107: Include basic scopes information in 'backtrace' response (Closed)

Created:
11 years, 6 months ago by yurys
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Sending scope types and object refs costs nothing but would save us request that should be send to retrieve scopes informations for each frame in 'backtrace' response. Committed: http://code.google.com/p/v8/source/detail?r=2237

Patch Set 1 #

Total comments: 5

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/mirror-delay.js View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
11 years, 6 months ago (2009-06-19 13:01:48 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/131107/diff/1/2 File src/mirror-delay.js (right): http://codereview.chromium.org/131107/diff/1/2#newcode2240 Line 2240: type: scope.scopeType(), I think you ahould add ...
11 years, 6 months ago (2009-06-22 06:42:28 UTC) #2
yurys
http://codereview.chromium.org/131107/diff/1/2 File src/mirror-delay.js (right): http://codereview.chromium.org/131107/diff/1/2#newcode2240 Line 2240: type: scope.scopeType(), On 2009/06/22 06:42:28, Søren Gjesse wrote: ...
11 years, 6 months ago (2009-06-22 07:21:56 UTC) #3
yurys
11 years, 6 months ago (2009-06-22 08:45:19 UTC) #4
http://codereview.chromium.org/131107/diff/1/2
File src/mirror-delay.js (right):

http://codereview.chromium.org/131107/diff/1/2#newcode2241
Line 2241: ref: scope.scopeObject().handle()
On 2009/06/22 06:42:28, Søren Gjesse wrote:
> For transient scope objects (negative handles) you should skip the ref to the
> handle, as it cannot be retrieved through that id anyway.
What do you mean by 'it cannot be retrieved through that id', the scope object
mirror is put into the mirror cache in MakeMirror?

Powered by Google App Engine
This is Rietveld 408576698