Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Issue 131101: Initial implementation of printing the AST as a JSON string. This... (Closed)

Created:
11 years, 6 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Initial implementation of printing the AST as a JSON string. This implementation is not yet complete (it prints only the node name for some AST constructs) and does not serialize everything needed to reconstitute the AST. It is motivated by a desire to prototype source-to-source transformations in JavaScript itself (or anything else that can grok JSON), but it should have other uses too. Feedback is welcome. Committed: http://code.google.com/p/v8/source/detail?r=3051

Patch Set 1 #

Total comments: 3

Patch Set 2 : Initial implementation of printing the AST as a JSON string. This... #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+536 lines, -9 lines) Patch
M src/ast.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ast.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/codegen.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/prettyprinter.h View 1 2 4 chunks +109 lines, -9 lines 0 comments Download
M src/prettyprinter.cc View 1 1 chunk +408 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Kevin Millikin (Chromium)
11 years, 6 months ago (2009-06-19 09:24:48 UTC) #1
mnaganov (inactive)
LGTM I'm curious, what will you do with a transformed AST? Just look at it, ...
11 years, 6 months ago (2009-06-19 10:20:11 UTC) #2
mnaganov (inactive)
http://codereview.chromium.org/131101/diff/1/2 File src/prettyprinter.cc (right): http://codereview.chromium.org/131101/diff/1/2#newcode1183 Line 1183: Print(text); On 2009/06/19 10:20:11, Michail Naganov wrote: > ...
11 years, 6 months ago (2009-06-19 11:53:39 UTC) #3
Søren Thygesen Gjesse
LGTM Should we add something to the debugger protocol to retrieve the AST?
11 years, 5 months ago (2009-07-01 16:46:11 UTC) #4
Kevin Millikin (Chromium)
I've addressed the comments and resurrected this to land it on bleeding_edge. It's still incomplete. ...
11 years, 2 months ago (2009-10-12 14:14:45 UTC) #5
fschneider
11 years, 2 months ago (2009-10-12 14:51:47 UTC) #6
LGTM!

Powered by Google App Engine
This is Rietveld 408576698