Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 131100: Add generations to the compilation cache for eval and regexp (Closed)

Created:
11 years, 6 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Add generations to the compilation cache for eval and regexp. The number of generations for these are set to two. BUG=none TEST=none This change has been dropped. Obsoleted by: http://codereview.chromium.org/140056.

Patch Set 1 #

Total comments: 7

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -110 lines) Patch
M src/compilation-cache.h View 1 4 chunks +96 lines, -14 lines 0 comments Download
M src/compilation-cache.cc View 1 10 chunks +171 lines, -96 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 6 months ago (2009-06-19 08:57:01 UTC) #1
Kasper Lund
Comments: http://codereview.chromium.org/131100/diff/1/3 File src/compilation-cache.cc (right): http://codereview.chromium.org/131100/diff/1/3#newcode58 Line 58: The rest of the file has two ...
11 years, 6 months ago (2009-06-19 09:10:45 UTC) #2
Kasper Lund
11 years, 6 months ago (2009-06-19 09:13:04 UTC) #3
http://codereview.chromium.org/131100/diff/1/3
File src/compilation-cache.cc (right):

http://codereview.chromium.org/131100/diff/1/3#newcode231
Line 231: if (generation != SCRIPT) PutScript(source, boilerplate);
This should be generation != 0.

Powered by Google App Engine
This is Rietveld 408576698