Issue 13108: Linux: use other fonts when the primary is missing glyphs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13108: Linux: use other fonts when the primary is missing glyphs (Closed)

Created:
12 years ago by agl

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Linux: use other fonts when the primary is missing glyphs We had a bug where we weren't setting the fontdata for missing glyphs to NULL. This caused WebKit not to try to load other fonts when glyphs were missing. With that fixed, we can implement the code to find a font for a given set of code points. This uses fontconfig as it has this information already indexed. This fixes css2.1/t0805-c5519-brdr-r-00-a.html

Patch Set 1 #

Patch Set 2 : Addressing comments #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -8 lines)			Patch
M	build/install-build-deps.sh	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/port/platform/graphics/chromium/FontCacheLinux.cpp	View	1	5 chunks	+42 lines, -6 lines	0 comments	Download
M	webkit/port/platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_gtk.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

12 years ago (2008-12-03 22:55:48 UTC) #2

LGTM

http://codereview.chromium.org/13108/diff/1/2
File webkit/port/platform/graphics/chromium/FontCacheLinux.cpp (right):

http://codereview.chromium.org/13108/diff/1/2#newcode21
Line 21: #include <fontconfig/fontconfig.h>
I think we put system headers above our local headers.  (So around L7 above.)

http://codereview.chromium.org/13108/diff/1/4
File webkit/tools/test_shell/test_shell_gtk.cc (right):

http://codereview.chromium.org/13108/diff/1/4#newcode98
Line 98: "/usr/share/fonts/truetype/ttf-lucida/LucidaSansRegular.ttf",
I guess needs to be added to the dependency list (wiki and
build/install-build-deps.sh).

% dpkg -S /usr/share/fonts/truetype/ttf-lucida
sun-java6-fonts: /usr/share/fonts/truetype/ttf-lucida

*sigh*

Expand Messages | Collapse Messages