Add svn:mime-type canned checks.

tests/presubmit_unittest.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for presubmit_support.py and presubmit_canned_checks.py."""
 
 import exceptions
 import os
 import StringIO
@@ skipping 980 matching lines @@
 
   def testMembersChanged(self):
     self.mox.ReplayAll()
     members = [
       'CheckChangeHasBugField', 'CheckChangeHasDescription',
       'CheckChangeHasNoStrayWhitespace',
       'CheckChangeHasOnlyOneEol', 'CheckChangeHasNoCR',
       'CheckChangeHasNoCrAndHasOnlyOneEol', 'CheckChangeHasNoTabs',
       'CheckChangeHasQaField', 'CheckChangeHasTestedField',
       'CheckChangeHasTestField', 'CheckChangeSvnEolStyle',
+      'CheckSvnForCommonMimeTypes', 'CheckSvnProperty',
       'CheckDoNotSubmit',
       'CheckDoNotSubmitInDescription', 'CheckDoNotSubmitInFiles',
       'CheckLongLines', 'CheckTreeIsOpen', 'RunPythonUnitTests',
     ]
     # If this test fails, you should add the relevant test.
     self.compareMembers(presubmit_canned_checks, members)
 
   def DescriptionTest(self, check, description1, description2, error_type,
                       committing):
     change1 = presubmit.Change('foo1', description1, self.fake_root_dir, None,
@@ skipping 56 matching lines @@
     affected_file2.LocalPath().AndReturn('bar.cc')
     self.mox.ReplayAll()
 
     results = check(input_api1, presubmit.OutputApi)
     self.assertEquals(results, [])
     results2 = check(input_api2, presubmit.OutputApi)
     self.assertEquals(len(results2), 1)
     self.assertEquals(results2[0].__class__, error_type)
 
   def SvnPropertyTest(self, check, property, value1, value2, committing,
-                      error_type):
+                      error_type, use_source_file):
     input_api1 = self.MockInputApi(None, committing)
     files1 = [
       presubmit.SvnAffectedFile('foo/bar.cc', 'A'),
       presubmit.SvnAffectedFile('foo.cc', 'M'),
     ]
-    input_api1.AffectedSourceFiles(None).AndReturn(files1)
+    if use_source_file:
+      input_api1.AffectedSourceFiles(None).AndReturn(files1)
+    else:
+      input_api1.AffectedFiles(include_deleted=False).AndReturn(files1)
     presubmit.gcl.GetSVNFileProperty(presubmit.normpath('foo/bar.cc'),
                                      property).AndReturn(value1)
     presubmit.gcl.GetSVNFileProperty(presubmit.normpath('foo.cc'),
                                      property).AndReturn(value1)
     input_api2 = self.MockInputApi(None, committing)
     files2 = [
       presubmit.SvnAffectedFile('foo/bar.cc', 'A'),
       presubmit.SvnAffectedFile('foo.cc', 'M'),
     ]
-    input_api2.AffectedSourceFiles(None).AndReturn(files2)
+    if use_source_file:
+      input_api2.AffectedSourceFiles(None).AndReturn(files2)
+    else:
+      input_api2.AffectedFiles(include_deleted=False).AndReturn(files2)
+    
     presubmit.gcl.GetSVNFileProperty(presubmit.normpath('foo/bar.cc'),
                                      property).AndReturn(value2)
     presubmit.gcl.GetSVNFileProperty(presubmit.normpath('foo.cc'),
                                      property).AndReturn(value2)
     self.mox.ReplayAll()
 
     results1 = check(input_api1, presubmit.OutputApi, None)
     self.assertEquals(results1, [])
     results2 = check(input_api2, presubmit.OutputApi, None)
     self.assertEquals(len(results2), 1)
@@ skipping 79 matching lines @@
     self.ContentTest(presubmit_canned_checks.CheckChangeHasNoTabs,
                      'blah blah', 'blah\tblah',
                      presubmit.OutputApi.PresubmitPromptWarning)
 
   def testCannedCheckLongLines(self):
     check = lambda x,y,z: presubmit_canned_checks.CheckLongLines(x, y, 10, z)
     self.ContentTest(check, '', 'blah blah blah',
                      presubmit.OutputApi.PresubmitPromptWarning)
 
   def testCheckChangeSvnEolStyleCommit(self):
+    # Test CheckSvnProperty at the same time.
     self.SvnPropertyTest(presubmit_canned_checks.CheckChangeSvnEolStyle,
                          'svn:eol-style', 'LF', '', True,
-                         presubmit.OutputApi.PresubmitError)
+                         presubmit.OutputApi.PresubmitError, True)
 
   def testCheckChangeSvnEolStyleUpload(self):
     self.SvnPropertyTest(presubmit_canned_checks.CheckChangeSvnEolStyle,
                          'svn:eol-style', 'LF', '', False,
-                         presubmit.OutputApi.PresubmitNotifyResult)
+                         presubmit.OutputApi.PresubmitNotifyResult, True)
+
+  def testCheckSvnForCommonMimeTypes(self):
+    self.mox.StubOutWithMock(presubmit_canned_checks, 'CheckSvnProperty')
+    input_api = self.MockInputApi(None, False)
+    output_api = presubmit.OutputApi()
+    input_api.AffectedFiles(include_deletes=False).AndReturn([
+        'a.pdf', 'b.bmp', 'c.gif', 'd.png', 'e.jpg', 'f.ico'])
+    presubmit_canned_checks.CheckSvnProperty(
+        input_api, output_api, 'svn:mime-type', 'application/pdf', ['a.pdf']
+        ).AndReturn([1])
+    presubmit_canned_checks.CheckSvnProperty(
+        input_api, output_api, 'svn:mime-type', 'image/bmp', ['b.bmp']
+        ).AndReturn([2])
+    presubmit_canned_checks.CheckSvnProperty(
+        input_api, output_api, 'svn:mime-type', 'image/gif', ['c.gif']
+        ).AndReturn([3])
+    presubmit_canned_checks.CheckSvnProperty(
+        input_api, output_api, 'svn:mime-type', 'image/png', ['d.png']
+        ).AndReturn([4])
+    presubmit_canned_checks.CheckSvnProperty(
+        input_api, output_api, 'svn:mime-type', 'image/jpeg', ['e.jpg']
+        ).AndReturn([5])
+    presubmit_canned_checks.CheckSvnProperty(
+        input_api, output_api, 'svn:mime-type', 'image/vnd.microsoft.icon',
+        ['f.ico']).AndReturn([6])
+    self.mox.ReplayAll()
+
+    results = presubmit_canned_checks.CheckSvnForCommonMimeTypes(
+        input_api, output_api)
+    self.assertEquals(results, [1, 2, 3, 4, 5, 6])
 
   def testCannedCheckTreeIsOpenOpen(self):
     input_api = self.MockInputApi(None, True)
     connection = self.mox.CreateMockAnything()
     input_api.urllib2.urlopen('url_to_open').AndReturn(connection)
     connection.read().AndReturn('1')
     connection.close()
     self.mox.ReplayAll()
     results = presubmit_canned_checks.CheckTreeIsOpen(
         input_api, presubmit.OutputApi, url='url_to_open', closed='0')
@@ skipping 143 matching lines @@
     test_result.errors = 0
     self.mox.ReplayAll()
 
     results = presubmit_canned_checks.RunPythonUnitTests(
         input_api, presubmit.OutputApi, ['test_module'])
     self.assertEquals(len(results), 0)
 
 
 if __name__ == '__main__':
   unittest.main()