Add svn:mime-type canned checks.

presubmit_canned_checks.py

 #!/usr/bin/env python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 
 ### Description checks
 
@@ skipping 171 matching lines @@
 
   if bad:
     msg = "Found lines longer than %s characters (first 5 shown)." % maxlen
     return [output_api.PresubmitPromptWarning(msg, items=bad)]
   else:
     return []
 
 
 def CheckChangeSvnEolStyle(input_api, output_api, source_file_filter=None):
   """Checks that the source files have svn:eol-style=LF."""
-  bad = filter(lambda f: f.scm == 'svn' and f.Property('svn:eol-style') != 'LF',
-               input_api.AffectedSourceFiles(source_file_filter))
+  return CheckSvnProperty(input_api, output_api,
+                          'svn:eol-style', 'LF',
+                          input_api.AffectedSourceFiles(source_file_filter))
+
+
+def CheckSvnForCommonMimeTypes(input_api, output_api):
+  """Checks that common binary file types have the correct svn:mime-type."""
+  output = []
+  files = input_api.AffectedFiles(include_deletes=False)
+  def FilterFiles(extension):
+    return filter(lambda x: x.endswith(extension), files)
+  def JpegFiles():
+    return filter(lambda x: (x.endswith('.jpg') or x.endswith('.jpeg') or
+                             x.endswith('.jpe')),
+                  files)
+  def RunCheck(mime_type, files):
+    output.extend(CheckSvnProperty(input_api, output_api, 'svn:mime-type',
+                                   mime_type, files))
+  RunCheck('application/pdf', FilterFiles('.pdf'))
+  RunCheck('image/bmp', FilterFiles('.bmp'))
+  RunCheck('image/gif', FilterFiles('.gif'))
+  RunCheck('image/png', FilterFiles('.png'))
+  RunCheck('image/jpeg', JpegFiles())
+  RunCheck('image/vnd.microsoft.icon', FilterFiles('.ico'))
+  return output
+
+
+def CheckSvnProperty(input_api, output_api, prop, expected, affected_files):
+  """Checks that affected_files files have prop=expected."""
+  bad = filter(lambda f: f.scm == 'svn' and f.Property(prop) != expected,
+               affected_files)
   if bad:
     if input_api.is_committing:
-      return [output_api.PresubmitError(
-            "Run `svn pset svn:eol-style LF <item>` on these files:",
-            items=bad)]
+      type = output_api.PresubmitError
     else:
-      return [output_api.PresubmitNotifyResult(
-            "Run `svn pset svn:eol-style LF <item>` on these files:",
-            items=bad)]
+      type = output_api.PresubmitNotifyResult
+    message = "Run `svn pset %s %s <item>` on these files:" % (prop, expected)
+    return [type(message, items=bad)]
   return []
 
 
 ### Other checks
 
 def CheckDoNotSubmit(input_api, output_api):
   return (
       CheckDoNotSubmitInDescription(input_api, output_api) +
       CheckDoNotSubmitInFiles(input_api, output_api)
       )
@@ skipping 41 matching lines @@
                                   long_text=input_api.traceback.format_exc()))
 
   buffer = input_api.cStringIO.StringIO()
   results = input_api.unittest.TextTestRunner(stream=buffer, verbosity=0).run(
       input_api.unittest.TestSuite(tests_suite))
   if not results.wasSuccessful():
     outputs.append(message_type("%d unit tests failed." %
                                 (len(results.failures) + len(results.errors)),
                                 long_text=buffer.getvalue()))
   return outputs