Chromium Code Reviews

Issue 131033: Fix 'nm' results parsing in tickprocessor. (Closed)

Created:
11 years, 6 months ago by Mikhail Naganov
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Fix 'nm' results parsing in tickprocessor. Without an explicit check if a function belongs to shared library address space, "finishing" a library symbols processing with 'addPrevEntry(libEnd);' can cause emission of code entries which cover almost the entire address space, shadowing other code. Committed: http://code.google.com/p/v8/source/detail?r=2221

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+3 lines, -1 line)
M tools/tickprocessor.js View 1 chunk +3 lines, -1 line 0 comments

Messages

Total messages: 2 (0 generated)
Mikhail Naganov
11 years, 6 months ago (2009-06-18 14:34:29 UTC) #1
Erik Corry
11 years, 6 months ago (2009-06-18 19:08:48 UTC) #2
LGTM

Powered by Google App Engine