Issue 131031: Revert the addition of -fno-threadsafe-statics. It breaks the build:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131031: Revert the addition of -fno-threadsafe-statics. It breaks the build: (Closed)

Created:
11 years, 6 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Revert the addition of -fno-threadsafe-statics. It breaks the build: cc1: warning: command line option "-fno-threadsafe-statics" is valid for C++/ObjC++ but not for C From what I can find, GYP has not separation between C and C++ flags :(

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	build/common.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

11 years, 6 months ago (2009-06-18 10:49:26 UTC) #1

I had thought -fno-exceptions would have only been valid in C++ code also, which
is why I thought adding this here would be safe.

Is there not a separation between c and c++ flags?  How do I solve this?

Expand Messages | Collapse Messages