Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 131029: X64 implementation: Add function literals and function calls. (Closed)

Created:
11 years, 6 months ago by William Hesse
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

X64 implementation: Add function literals and function calls. Committed: http://code.google.com/p/v8/source/detail?r=2217

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+431 lines, -16 lines) Patch
M src/ia32/assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/codegen-x64.cc View 7 chunks +247 lines, -9 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 3 chunks +54 lines, -0 lines 1 comment Download
M src/x64/virtual-frame-x64.cc View 3 chunks +126 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
We now want to run the tests with --nouse-is and --nolazy, as well as using ...
11 years, 6 months ago (2009-06-18 08:17:33 UTC) #1
Lasse Reichstein
LGTM http://codereview.chromium.org/131029/diff/1/4 File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/131029/diff/1/4#newcode216 Line 216: movq(target, code, RelocInfo::EXTERNAL_REFERENCE); // Is external reference? ...
11 years, 6 months ago (2009-06-18 10:57:54 UTC) #2
Lasse Reichstein
11 years, 6 months ago (2009-06-18 10:58:49 UTC) #3
Put the flags in every time we run (and make local shell scripts to help
ourselves).

Powered by Google App Engine
This is Rietveld 408576698