Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 131028: Use 'cp' not 'copy' to copy in the FirstRun file, since the gyp msvs... (Closed)

Created:
11 years, 6 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Use 'cp' not 'copy' to copy in the FirstRun file, since the gyp msvs generator uses Cygwin's bash and not cmd to execute commands. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18695

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/chrome.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sgk
TBR=bradnelson
11 years, 6 months ago (2009-06-18 07:19:00 UTC) #1
bradn
11 years, 6 months ago (2009-06-18 17:43:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698