Add favicons to tabs on the Mac

Add favicons to tabs on the Mac. Also moved SkBitmapToNSImage() to
skia/ext/skia_utils_mac.h and removed chrome/browser/cocoa/cocoa_utils.h.
BUG=13565

[pink (ping after 24hrs), 2009-06-18 15:28:36]

LGTM with small things.

http://codereview.chromium.org/131018/diff/22/27
File chrome/browser/cocoa/tab_strip_controller.mm (right):

http://codereview.chromium.org/131018/diff/22/27#newcode430
Line 430: if (favIcon.is_valid() && !bitmap.isNull())
what happens if this isn't loaded yet by the time we ask for it? when do we get
triggered again?

http://codereview.chromium.org/131018/diff/22/27#newcode436
Line 436: image = [NSImage imageNamed:@"nav"];
can you change this to load from the proper bundle? Will make the unit test
happier.

http://codereview.chromium.org/131018/diff/22/30
File skia/ext/skia_utils_mac.mm (right):

http://codereview.chromium.org/131018/diff/22/30#newcode18
Line 18: // Callback passed to CGDataProviderCreateWithData()
don't indent things in namespaces.

[---DO NOT USE---rsesek, 2009-06-18 15:53:43]

http://codereview.chromium.org/131018/diff/22/27
File chrome/browser/cocoa/tab_strip_controller.mm (right):

http://codereview.chromium.org/131018/diff/22/27#newcode430
Line 430: if (favIcon.is_valid() && !bitmap.isNull())
On 2009/06/18 15:28:36, pink wrote:
> what happens if this isn't loaded yet by the time we ask for it? when do we
get
> triggered again?

Yes, we get called from TabStripModelObserverBridge::TabChangedAt() which gets
notified whenever the tab needs to be re-drawn.

http://codereview.chromium.org/131018/diff/22/27#newcode436
Line 436: image = [NSImage imageNamed:@"nav"];
On 2009/06/18 15:28:36, pink wrote:
> can you change this to load from the proper bundle? Will make the unit test
> happier.

Done.

http://codereview.chromium.org/131018/diff/22/30
File skia/ext/skia_utils_mac.mm (right):

http://codereview.chromium.org/131018/diff/22/30#newcode18
Line 18: // Callback passed to CGDataProviderCreateWithData()
On 2009/06/18 15:28:36, pink wrote:
> don't indent things in namespaces.

Done.

[pink (ping after 24hrs), 2009-06-18 16:04:55]

LGTM

[pink (ping after 24hrs), 2009-06-18 18:20:50]

still LGTM

[Avi (use Gerrit), 2009-06-18 20:25:58]

Committed r18743.

[Avi (use Gerrit), 2009-06-18 21:35:20]

On 2009/06/18 20:25:58, Avi wrote:
> Committed r18743.

Reverting. We'll take another shot at it tomorrow.

[Avi (use Gerrit), 2009-06-25 13:50:37]

http://codereview.chromium.org/131018/diff/4001/5008
File skia/ext/skia_utils_mac.mm (right):

http://codereview.chromium.org/131018/diff/4001/5008#newcode19
Line 19: void ReleaseData(void* info, const void* pixelData, size_t size) {
Why do you still define this? It hasn't been needed since a few versions ago.

[Avi (use Gerrit), 2009-06-25 13:59:09]

Removed on commit.

Committed r19244.

[Avi (use Gerrit), 2009-06-25 14:24:04]

Reverted r19245, as it broke ui tests: OtherRedirectsDontForkProcess
InEmptyFrame TestLifetimeOfDomAutomationController

[Avi (use Gerrit), 2009-06-25 19:12:51]

On 2009/06/25 14:24:04, Avi wrote:
> Reverted r19245, as it broke ui tests: OtherRedirectsDontForkProcess
> InEmptyFrame TestLifetimeOfDomAutomationController

Committed r19266. For reals this time.