Issue 13101: Move base/gfx/skia_util to skia/ext/skia_util_win....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13101: Move base/gfx/skia_util to skia/ext/skia_util_win.... (Closed)

Created:
12 years ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move base/gfx/skia_util to skia/ext/skia_util_win. In a later pass, I will separate off the cross-platform part of this file into skia/ext/skia_util (only one function). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6306

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -162 lines)			Patch
M	base/build/base_gfx.vcproj	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	base/gfx/base_gfx.scons	View	2 chunks	+0 lines, -2 lines	0 comments	Download
D	base/gfx/skia_utils.h	View	1 chunk	+0 lines, -56 lines	0 comments	Download
D	base/gfx/skia_utils.cc	View	1 chunk	+0 lines, -75 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/bookmark_bar_view.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/options/content_page_view.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/options/fonts_page_view.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/views/options/languages_page_view.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/views/options/options_group_view.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/gfx/color_utils.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/views/background.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/views/chrome_menu.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/views/single_split_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/views/tabbed_pane.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/views/table_view.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/views/text_field.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	skia/SConscript	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	skia/ext/platform_device_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
	skia/ext/skia_utils_win.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	skia/ext/skia_utils_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
	skia/ext/vector_device.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/skia.vcproj	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	webkit/port/platform/graphics/PlatformContextSkia.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/port/rendering/RenderThemeWin.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages