Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 131007: Linux: Enable metrics_service_uitest.cc. Take 2. (Closed)

Created:
11 years, 6 months ago by willchan no longer on Chromium
Modified:
9 years, 7 months ago
Reviewers:
agl
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: Enable metrics_service_uitest.cc. Take 2. Relands r18641, original code review: http://codereview.chromium.org/125268 Expect a crash on Windows. The old method of crashing was flawed on posix (KillProcess just does a SIGTERM). On Windows though, it would terminate the process with the desired exit code, in order to make DidProcessCrash() return true. This process termination does not dump crash information though, since it just forcibly terminates the process, like a SIGKILL on posix. When I switched it to navigate to about:crash though, it actually crashes, and dumps crash information, which the UITest in windows (but not linux/mac) detects. Therefore, until those platforms can detect, we just use #if defined(OS_WIN) around the expected_crashes = 1. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -24 lines) Patch
M base/process.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_service_uitest.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +12 lines, -1 line 0 comments Download
M chrome/browser/zygote_host_linux.h View 2 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser/zygote_host_linux.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M chrome/browser/zygote_main_linux.cc View 2 chunks +35 lines, -10 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
willchan no longer on Chromium
11 years, 6 months ago (2009-06-18 00:16:43 UTC) #1
agl
11 years, 6 months ago (2009-06-18 00:25:05 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698