Issue 131002: Enable off-by-default monitor color management on Windows. This is enabled vi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131002: Enable off-by-default monitor color management on Windows. This is enabled vi... (Closed)

Created:
11 years, 6 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Enable off-by-default monitor color management on Windows. This is enabled via a command-line switch. BUG=4938 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18675

Patch Set 1 #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -2 lines)			Patch
M	chrome/browser/renderer_host/backing_store.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/backing_store_win.cc	View	2 chunks	+35 lines, -2 lines	2 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_win.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

11 years, 6 months ago (2009-06-18 00:19:09 UTC) #2

I assume for the moment you don't care about RDP but making it a static local
variable make it harder to refactor in the case we want to fix this use case.

http://codereview.chromium.org/131002/diff/1/2
File chrome/browser/renderer_host/backing_store_win.cc (right):

http://codereview.chromium.org/131002/diff/1/2#newcode30
Line 30: hdr.bV5ClrUsed = 0;
nit: Do you really want to keep the = 0?

http://codereview.chromium.org/131002/diff/1/2#newcode79
Line 79: static bool enabled = false;
humm...

There's one issue I easily see is RDP session. I guess this function is called
very often so it'd be costly to be looking at the command line at each call. I
still don't like static local variable.

Expand Messages | Collapse Messages