Issue 1307001: revinfo: Properly use git HEAD or svn BASE revisions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1307001: revinfo: Properly use git HEAD or svn BASE revisions (Closed)

Created:
10 years, 9 months ago by Nasser Grainawi

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel, jneddo1

CC:
chromium-reviews, cros.approvers_codeaurora.org

Visibility:
Public.

Description

revinfo: Properly use git HEAD or svn BASE revisions BUG=http://crosbug.com/1658 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42555

Patch Set 2 : fixed issues with patch set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -23 lines)			Patch
M	gclient.py	View	1	3 chunks	+16 lines, -19 lines	0 comments	Download
M	gclient_scm.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	scm.py	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	tests/scm_unittest.py	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

You'll break unit tests. Once fixed, lgtm. http://codereview.chromium.org/1307001/diff/1/2 File gclient.py (right): http://codereview.chromium.org/1307001/diff/1/2#newcode839 gclient.py:839: url, revision ...

10 years, 9 months ago (2010-03-24 20:23:59 UTC) #2

lgtm

Expand Messages | Collapse Messages

Issue 1307001: revinfo: Properly use git HEAD or svn BASE revisions (Closed)

Description

Patch Set 1 #

Patch Set 2 : fixed issues with patch set 1 #

Messages