Issue 13065: Protect the exception handler against failure to create semaphores & a thread...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13065: Protect the exception handler against failure to create semaphores & a thread... (Closed)

Created:
12 years ago by mad-home

Modified:
9 years, 7 months ago

Reviewers:
mmentovai, mmentovai, Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src/

Visibility:
Public.

Description

Protect the exception handler against failure to create semaphores & a thread handle and get caught in a deadlock if so. We simply won't create the thread if we couldn't create the semaphores, and won't wait for the thread if we couldn't create it. BUG=285 Closed by mark on 2009-10-24 - looks like I committed this to Breakpad at r300 on 2008-12-03.

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -7 lines)			Patch
	M	client/windows/handler/exception_handler.cc	View		3 chunks	+27 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mad-home

To fix http://code.google.com/p/google-breakpad/issues/detail?id=285 Thanks! BYE MAD

12 years ago (2008-12-02 22:40:36 UTC) #1

lgtm

Expand Messages | Collapse Messages