Issue 13052: Cleanup: move base/platform_test.h -> testing/

Issue 13052: Cleanup: move base/platform_test.h -> testing/ (Closed)

Created:
12 years ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai, pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

* Cleanup: move base/platform_test.h -> testing/ * Add support for "Debug On Start" switch to MultiprocessTest::SpawnChild

Patch Set 1 #

Patch Set 2 : split debug_on_start out from this CL #

Patch Set 3 : try split again #

Patch Set 4 : patch really split this time #

Patch Set 5 : fix mark's comment #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -107 lines)			Patch
M	base/base.xcodeproj/project.pbxproj	View		4 chunks	+0 lines, -6 lines	0 comments	Download
M	base/clipboard_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/condition_variable_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/file_util_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/multiprocess_test.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	base/path_service_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/platform_test.h	View		1 chunk	+0 lines, -37 lines	0 comments	Download
M	base/platform_test_mac.mm	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	base/sys_info_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/thread_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/worker_pool_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chrome_thread_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/text_database_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome.xcodeproj/project.pbxproj	View	1	5 chunks	+0 lines, -13 lines	0 comments	Download
M	net/base/bzip2_filter_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/file_stream_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/gzip_filter_unittest.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/listen_socket_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/ssl_client_socket_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	net/base/tcp_client_socket_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	net/base/telnet_server_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/test_completion_callback_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/disk_cache_perftest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	net/disk_cache/disk_cache_test_base.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/http/http_network_layer_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/http/http_network_transaction_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	net/net.xcodeproj/project.pbxproj	View		5 chunks	+0 lines, -13 lines	0 comments	Download
M	net/url_request/url_request_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	testing/gtest.xcodeproj/project.pbxproj	View		4 chunks	+6 lines, -0 lines	0 comments	Download
A	testing/platform_test.h	View		1 chunk	+36 lines, -0 lines	0 comments	Download
A	testing/platform_test_mac.mm	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

The platform_test.h move to testing looks good. Can you move the debug-on-start change and the ...

12 years ago (2008-12-02 17:32:20 UTC) #3

Mark Mentovai

12 years ago (2008-12-02 18:23:13 UTC) #5

lg™

http://codereview.chromium.org/13052/diff/38/324
File net/base/gzip_filter_unittest.cc (right):

http://codereview.chromium.org/13052/diff/38/324#newcode14
Line 14: #include "testing/platform_test.h"
Should go with the other testing #include

Expand Messages | Collapse Messages