Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Issue 13039: Fixes and enhancements... (Closed)

Created:
12 years ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
tony, tc
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fixes and enhancements * Configurable CHROME_BUILD_TYPE command line or external environment variable for selecting appropriate release_impl*.scons settings (_checksenabled, _coverage, _dom_stats, _official, _purify). * Configurable CHROMIUM_BUILD command line or external environment variable for selecting appropriate chromium_build*.scons settings (_google_chrome). * Configurable /INCREMENTAL linking via command line or external environment variable ($INCREMENTAL), through appropriate setting of an internal $CHROMIUM_INCREMENTAL_FLAGS construction variable. * Full link of release builds by default. * Alphabetize *.scons files in the mac_env.FilterOut() list. * Explicitly set _checksenabled.scons link flags. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6210

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -37 lines) Patch
M base/base_unittests.scons View 1 chunk +0 lines, -6 lines 0 comments Download
M build/SConscript.main View 1 4 chunks +39 lines, -17 lines 0 comments Download
M build/debug.scons View 2 chunks +6 lines, -1 line 0 comments Download
M build/internal/essential.scons View 1 chunk +7 lines, -0 lines 0 comments Download
M build/internal/release_defaults.scons View 1 chunk +6 lines, -0 lines 0 comments Download
M build/internal/release_impl_checksenabled.scons View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/SConscript View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/browser.scons View 1 chunk +0 lines, -3 lines 0 comments Download
M site_scons/site_tools/chromium_builders.py View 2 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sgk
12 years ago (2008-12-02 03:26:49 UTC) #1
tony
LGTM http://codereview.chromium.org/13039/diff/1/2 File build/SConscript.main (right): http://codereview.chromium.org/13039/diff/1/2#newcode24 Line 24: ('CHROME_BUILD_TYPE', '', os.environ.get('CHROME_BUILD_TYPE', '')), Can you add ...
12 years ago (2008-12-02 05:06:47 UTC) #2
sgk
12 years ago (2008-12-02 07:35:48 UTC) #3
http://codereview.chromium.org/13039/diff/1/2
File build/SConscript.main (right):

http://codereview.chromium.org/13039/diff/1/2#newcode24
Line 24: ('CHROME_BUILD_TYPE', '', os.environ.get('CHROME_BUILD_TYPE', '')),
On 2008/12/02 05:06:48, tony wrote:
> Can you add a comment describing each of these environment vars?

Done.

Powered by Google App Engine
This is Rietveld 408576698