OpenBSD media/audio support

- OpenBSD media/audio support stub
- FreeBSD has ALSA, add it to media.gyp


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42699

[Evan Martin, 2010-03-25 21:11:17]

http://codereview.chromium.org/1301003/diff/19001/20004
File media/media.gyp (right):

http://codereview.chromium.org/1301003/diff/19001/20004#newcode143
media/media.gyp:143: ['OS =="openbsd"', {
weird spacing around ==

http://codereview.chromium.org/1301003/diff/19001/20004#newcode144
media/media.gyp:144: 'sources/': [ ['exclude', '_(mac|win)\\.cc$'],
This shouldn't be necessary; isn't it covered by the rules in common.gypi?

[Peter Valchev, 2010-03-25 21:40:25]

http://codereview.chromium.org/1301003/diff/19001/20004
File media/media.gyp (right):

http://codereview.chromium.org/1301003/diff/19001/20004#newcode143
media/media.gyp:143: ['OS =="openbsd"', {
On 2010/03/25 21:11:17, Evan Martin wrote:
> weird spacing around ==

agreed, the OS =="linux" above was the same though - just fixed all of them to
be consistent :)

http://codereview.chromium.org/1301003/diff/19001/20004#newcode144
media/media.gyp:144: 'sources/': [ ['exclude', '_(mac|win)\\.cc$'],
On 2010/03/25 21:11:17, Evan Martin wrote:
> This shouldn't be necessary; isn't it covered by the rules in common.gypi?

It is - I removed & tested, thanks

[Evan Martin, 2010-03-25 21:42:08]

LGTM

http://codereview.chromium.org/1301003/diff/21002/19002
File media/audio/openbsd/audio_manager_openbsd.cc (right):

http://codereview.chromium.org/1301003/diff/21002/19002#newcode1
media/audio/openbsd/audio_manager_openbsd.cc:1: // Copyright (c) 2006-2009 The
Chromium Authors. All rights reserved.
2010

http://codereview.chromium.org/1301003/diff/21002/19003
File media/audio/openbsd/audio_manager_openbsd.h (right):

http://codereview.chromium.org/1301003/diff/21002/19003#newcode1
media/audio/openbsd/audio_manager_openbsd.h:1: // Copyright (c) 2009 The
Chromium Authors. All rights reserved.
2010

http://codereview.chromium.org/1301003/diff/21002/19004
File media/base/yuv_row.h (right):

http://codereview.chromium.org/1301003/diff/21002/19004#newcode66
media/base/yuv_row.h:66: // Windows, Mac and Linux/BSD use MMX
I guess this comment is wrong, since Mac is specifically excluded?  I will bring
it up separately.

[Peter Valchev, 2010-03-25 21:47:28]

Thanks for the quick review! Will submit once the trybots pass..

http://codereview.chromium.org/1301003/diff/21002/19002
File media/audio/openbsd/audio_manager_openbsd.cc (right):

http://codereview.chromium.org/1301003/diff/21002/19002#newcode1
media/audio/openbsd/audio_manager_openbsd.cc:1: // Copyright (c) 2006-2009 The
Chromium Authors. All rights reserved.
On 2010/03/25 21:42:08, Evan Martin wrote:
> 2010

Done.

http://codereview.chromium.org/1301003/diff/21002/19003
File media/audio/openbsd/audio_manager_openbsd.h (right):

http://codereview.chromium.org/1301003/diff/21002/19003#newcode1
media/audio/openbsd/audio_manager_openbsd.h:1: // Copyright (c) 2009 The
Chromium Authors. All rights reserved.
On 2010/03/25 21:42:08, Evan Martin wrote:
> 2010

Done.

http://codereview.chromium.org/1301003/diff/21002/19004
File media/base/yuv_row.h (right):

http://codereview.chromium.org/1301003/diff/21002/19004#newcode66
media/base/yuv_row.h:66: // Windows, Mac and Linux/BSD use MMX
On 2010/03/25 21:42:08, Evan Martin wrote:
> I guess this comment is wrong, since Mac is specifically excluded?  I will
bring
> it up separately.

it's only excluded in the 64-bit case, i'm not familiar at all with mac to know
why though

[fbarchard, 2010-03-26 01:43:42]

Thanks for taking the initiative to do this patch!
Don't forget to update the copyright to 2010 on each file you touch.
LGTM

http://codereview.chromium.org/1301003/diff/21002/19004
File media/base/yuv_row.h (right):

http://codereview.chromium.org/1301003/diff/21002/19004#newcode66
media/base/yuv_row.h:66: // Windows, Mac and Linux/BSD use MMX
For Mac, its my intent to use the linux x264 code.  Does the Mac have a 64 bit
config now?
For BSD, is there a reason you cant use base/yuv_row_linux.cc?
It'll help video performance substantially.

[Peter Valchev, 2010-03-26 23:49:46]

http://codereview.chromium.org/1301003/diff/21002/19004
File media/base/yuv_row.h (right):

http://codereview.chromium.org/1301003/diff/21002/19004#newcode66
media/base/yuv_row.h:66: // Windows, Mac and Linux/BSD use MMX
On 2010/03/26 01:43:42, fbarchard wrote:
> For Mac, its my intent to use the linux x264 code.  Does the Mac have a 64 bit
> config now?
> For BSD, is there a reason you cant use base/yuv_row_linux.cc?
> It'll help video performance substantially.

Yes, yuv_row_linux.cc is actually used on BSD :) Most of the *_linux.cc are
actually OK to use on BSD and the gyp configs include them (and they exclude
only select ones that are truly linux-specific)

[fbarchard, 2010-03-30 01:51:02]

http://codereview.chromium.org/1301003/diff/21002/19004
File media/base/yuv_row.h (right):

http://codereview.chromium.org/1301003/diff/21002/19004#newcode66
media/base/yuv_row.h:66: // Windows, Mac and Linux/BSD use MMX
I wrote the mac code, and there is only 32 bit version.
But if there is a need for 64 bit, it would be better to port the 64 bit linux
code.