Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 1301001: Add all the strings required for the geolocation bubble, location bar icon, a... (Closed)

Created:
10 years, 9 months ago by joth
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add all the strings required for the geolocation bubble, location bar icon, and inforbar BUG=11246 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42599

Patch Set 1 #

Total comments: 18

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +32 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
joth
Adding in strings now, so we have something. (several taken from http://codereview.chromium.org/650180/diff/33001/34001 - thanks Marcus!) ...
10 years, 9 months ago (2010-03-24 19:20:55 UTC) #1
Peter Kasting
http://codereview.chromium.org/1301001/diff/1/2 File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/1301001/diff/1/2#newcode6850 chrome/app/generated_resources.grd:6850: <message name="IDS_GEOLOCATION_INFOBAR_EMBEDDED_QUESTION" desc="Question asked on the info bar whenever ...
10 years, 9 months ago (2010-03-24 19:31:16 UTC) #2
joth
10 years, 9 months ago (2010-03-25 10:36:54 UTC) #3
All done.
No other comments made about the wording, so I've made it consistent throughout
as suggested.
Thanks!
Joth

http://codereview.chromium.org/1301001/diff/1/2
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/1301001/diff/1/2#newcode6850
chrome/app/generated_resources.grd:6850: <message
name="IDS_GEOLOCATION_INFOBAR_EMBEDDED_QUESTION" desc="Question asked on the
info bar whenever embedded content from URL wants to access the user physical
location whilst on the current page">
On 2010/03/24 19:31:16, Peter Kasting wrote:
> Nit: user -> user's
> Up to you whether you want to Americanize whilst -> while... most of our
> comments seem to be in U.S. English, but I guess it doesn't matter as long as
> the translators understand

Done.

http://codereview.chromium.org/1301001/diff/1/2#newcode6861
chrome/app/generated_resources.grd:6861: <message
name="IDS_GEOLOCATION_BUBBLE_SECTION_ALLOWED" desc="Heading for a section in the
geolocation bubble listing all site which are currently tracking the user's
location">
On 2010/03/24 19:31:16, Peter Kasting wrote:
> Nit: site -> sites

Done.

http://codereview.chromium.org/1301001/diff/1/2#newcode6864
chrome/app/generated_resources.grd:6864: <message
name="IDS_GEOLOCATION_BUBBLE_SECTION_DENIED" desc="Heading for a section in the
geolocation bubble listing all site which are currently blocked from accessing
the user's location">
On 2010/03/24 19:31:16, Peter Kasting wrote:
> Nit: site -> sites

Done.

http://codereview.chromium.org/1301001/diff/1/2#newcode6865
chrome/app/generated_resources.grd:6865: The following sites have been blocked
from accessing your location on this page:
On 2010/03/24 19:31:16, Peter Kasting wrote:
> I think we should use "tracking" here for consistency.

Done.

http://codereview.chromium.org/1301001/diff/1/2#newcode6867
chrome/app/generated_resources.grd:6867: <message
name="IDS_GEOLOCATION_BUBBLE_SECTION_PENDING" desc="Heading for a section in the
geolocation bubble listing all site which are currently requesting the user's
location but have yet been either granted or denied access">
On 2010/03/24 19:31:16, Peter Kasting wrote:
> Nit: site -> sites; have yet -> have not yet; been either -> been

Done.

http://codereview.chromium.org/1301001/diff/1/2#newcode6870
chrome/app/generated_resources.grd:6870: <message
name="IDS_GEOLOCATION_BUBBLE_CLEAR_LINK" desc="Link on the geolocation bubble
that resets the list of allow and blocked sites">
On 2010/03/24 19:31:16, Peter Kasting wrote:
> Nit: allow -> allowed

Done.

http://codereview.chromium.org/1301001/diff/1/2#newcode6874
chrome/app/generated_resources.grd:6874: Manage my location settings
On 2010/03/24 19:31:16, Peter Kasting wrote:
> This should have "..." on the end.  For consistency with other bubbles'
strings,
> I think we should omit "my" as well.

Done.
"My" location bugged me, as that's a specific product feature already.

http://codereview.chromium.org/1301001/diff/1/2#newcode6880
chrome/app/generated_resources.grd:6880: This page has been blocked from
accessing your location.
On 2010/03/24 19:31:16, Peter Kasting wrote:
> I think we should use "tracking" here for consistency.

Done.

http://codereview.chromium.org/1301001/diff/1/2#newcode6883
chrome/app/generated_resources.grd:6883: This page is requesting access to your
location.
On 2010/03/24 19:31:16, Peter Kasting wrote:
> I think we should say "This page wants to track your location." for
consistency.

Done.

Powered by Google App Engine
This is Rietveld 408576698