Issue 13010: Remove the cpu-count forwarding passing code from the v8 SConscript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13010: Remove the cpu-count forwarding passing code from the v8 SConscript. (Closed)

Created:
12 years ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Remove the cpu-count forwarding passing code from the v8 SConscript. Running with n CPUs would cause our parent scons to run with n cpus and then have it spawn a sub-scons that would itself attempt to run with an additional n cpus.

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -9 lines)			Patch
	M	build/SConscript.v8	View		2 chunks	+2 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

LG, but I didn't understand the description. The problem is that you end up with ...

12 years ago (2008-12-01 02:43:54 UTC) #2

Evan Martin

12 years ago (2008-12-01 19:34:15 UTC) #3

On 2008/12/01 02:43:54, Dean McNamee wrote:
> LG, but I didn't understand the description.  The problem is that you end up
> with num_cpus*2 jobs?

Yes, exactly.

Expand Messages | Collapse Messages