Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: src/compiler.cc

Issue 12986: Checking and reporting for stack overflow in the right places. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
===================================================================
--- src/compiler.cc (revision 919)
+++ src/compiler.cc (working copy)
@@ -74,11 +74,6 @@
// Generate code and return it.
Handle<Code> result = CodeGenerator::MakeCode(literal, script, is_eval);
- // Check for stack-overflow exception.
- if (result.is_null()) {
- Top::StackOverflow();
- Top::ReportPendingMessages();
- }
return result;
}
@@ -123,6 +118,8 @@
// Check for stack-overflow exceptions.
if (code.is_null()) {
+ Top::StackOverflow();
+ Top::ReportPendingMessages();
return Handle<JSFunction>::null();
}
@@ -211,8 +208,6 @@
}
}
- if (result.is_null()) Top::ReportPendingMessages();
-
return result;
}
@@ -243,8 +238,6 @@
}
}
- if (result.is_null()) Top::ReportPendingMessages();
-
return result;
}
@@ -294,7 +287,10 @@
// Compile the code.
Handle<Code> code = MakeCode(lit, script, false);
+ // Check for stack-overflow exception.
if (code.is_null()) {
+ Top::StackOverflow();
+ Top::ReportPendingMessages();
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698