Partial fix for issue 173:...

Partial fix for issue 173:
- Do not keep growing the zone segment size exponentially. By putting
  an upper limit on the segment size we limit the requirements for
  contiguous memory allocation.


Committed: http://code.google.com/p/v8/source/detail?r=926

[Kasper Lund, 2008-12-05 08:36:48]

LGTM.

http://codereview.chromium.org/12984/diff/1/2
File src/zone.cc (right):

http://codereview.chromium.org/12984/diff/1/2#newcode166
Line 166: int segment_overhead = sizeof(Segment) + kAlignment;
This is a constant, right? Maybe make it 'static const int kSegmentOverhead'?

http://codereview.chromium.org/12984/diff/1/2#newcode177
Line 177: new_size = RoundUp(size + segment_overhead, kMinimumSegmentSize);
Why do you round the result up? If it's a feature to (maybe) leave some room in
the new segment, you may want to document that in a comment.

[iposva, 2008-12-05 17:25:13]

http://codereview.chromium.org/12984/diff/1/2
File src/zone.cc (right):

http://codereview.chromium.org/12984/diff/1/2#newcode166
Line 166: int segment_overhead = sizeof(Segment) + kAlignment;
On 2008/12/05 08:36:49, Kasper Lund wrote:
> This is a constant, right? Maybe make it 'static const int kSegmentOverhead'? 

Done.

http://codereview.chromium.org/12984/diff/1/2#newcode177
Line 177: new_size = RoundUp(size + segment_overhead, kMinimumSegmentSize);
The idea was to round up to a size that is likely going to be a page size, but
since segments are allocated using malloc, this is mostly useless.

I removed the RoundUp() call.

On 2008/12/05 08:36:49, Kasper Lund wrote:
> Why do you round the result up? If it's a feature to (maybe) leave some room
in
> the new segment, you may want to document that in a comment.